<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Verified that intrin0.h was available in 1910, by building it locally on VS2017 version 15.0</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<pre style="line-height: 1.3; font-family: monospace, monospace; background-color: rgb(248, 249, 250); border: 1px solid rgb(234, 236, 240); padding: 1em; overflow-x: hidden; overflow-wrap: break-word; tab-size: 4; font-size: 14px"><span>MSVC</span><span style="color: rgb(102, 102, 102)">++</span> <span style="color: rgb(102, 102, 102)">14.1</span> <span>_MSC_VER</span> <span style="color: rgb(102, 102, 102)">==</span> <span style="color: rgb(102, 102, 102)">1910</span> <span>(</span><span>Visual</span> <span>Studio</span> <span style="color: rgb(102, 102, 102)">2017</span> <span>version</span> <span style="color: rgb(102, 102, 102)">15.0</span><span>)</span></pre>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<a href="https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B">https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B</a><br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
//Marcus</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Marcus Asteborg <xnorpx@outlook.com><br>
<b>Sent:</b> Thursday, June 11, 2020 20:15<br>
<b>To:</b> Ralph Giles <giles@thaumas.net>; opus@xiph.org <opus@xiph.org><br>
<b>Subject:</b> Re: [opus] Misc patches</font>
<div> </div>
</div>
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Sorry about that, let me check the correct version for the intrin0.h include guard.</div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
//Marcus</div>
<div id="x_appendonsend"></div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Ralph Giles <giles@thaumas.net><br>
<b>Sent:</b> Thursday, June 11, 2020 19:31<br>
<b>To:</b> Marcus Asteborg <xnorpx@outlook.com>; opus@xiph.org <opus@xiph.org><br>
<b>Subject:</b> Re: [opus] Misc patches</font>
<div> </div>
</div>
<div class="x_BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="x_PlainText">Speaking of needing more complete ci feedback, the intrin0.h patch<br>
broke the appveyor build:<br>
<br>
> Microsoft (R) Build Engine version 14.0.25420.1<br>
> [...]<br>
> :\projects\opus\celt\ecintrin.h(53): fatal error C1083: Cannot open<br>
include file: 'intrin0.h': No such file or directory<br>
[C:\projects\opus\win32\VS2015\opus.vcxproj]<br>
<br>
<a href="https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Frillian%2Fopus%2Fbuilds%2F33474422&data=02%7C01%7C%7C4162e72343444c9c310608d80e78ad01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637275258756998152&sdata=1zMyaftA7NjAXL52YRlQtwyNG3Xaen2U7kngJ%2F8KZtU%3D&reserved=0">https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Frillian%2Fopus%2Fbuilds%2F33474422&data=02%7C01%7C%7C4162e72343444c9c310608d80e78ad01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637275258756998152&sdata=1zMyaftA7NjAXL52YRlQtwyNG3Xaen2U7kngJ%2F8KZtU%3D&reserved=0</a><br>
<br>
Is this an extra feature the appveyor environment doesn't apply, or is<br>
the version guard incorrect?<br>
<br>
-r<br>
<br>
On Mon, 2020-06-08 at 05:39 +0000, Marcus Asteborg wrote:<br>
> Hi,<br>
> <br>
> Here are 3 suggested patches.<br>
> Build test for cmake and run the test in gitlab-ci.<br>
> Disable the message box on Windows on abort that cause test hangs in<br>
> CI.<br>
> Build time improvement by removing unnecessary includes of stdio.h in<br>
> production code and change to a lighter header intrin.h -> intrin0.h<br>
> (windows only). Attached screenshot of measurement but it resulted in<br>
> 14% buildspeed compared to master on Windows 64 debug builds on my<br>
> setup. As most improvements comes from change intrin.h the impact on<br>
> other platforms will not be that much.<br>
> //Marcus<br>
> _______________________________________________<br>
> opus mailing list<br>
> opus@xiph.org<br>
> <a href="https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C4162e72343444c9c310608d80e78ad01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637275258757008148&sdata=wrR6%2FwZJoaV%2F7s36m3MglWx41ntOa3ZGXRwQh%2BU7cDU%3D&reserved=0">
https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C4162e72343444c9c310608d80e78ad01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637275258757008148&sdata=wrR6%2FwZJoaV%2F7s36m3MglWx41ntOa3ZGXRwQh%2BU7cDU%3D&reserved=0</a><br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>