<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
3, no good catch attached is an updated patch</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
//Marcus</div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Jean-Marc Valin <jmvalin@jmvalin.ca><br>
<b>Sent:</b> Thursday, June 11, 2020 10:49<br>
<b>To:</b> Marcus Asteborg <xnorpx@outlook.com>; opus@xiph.org <opus@xiph.org><br>
<b>Subject:</b> Re: [opus] Misc patches</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">On 2020-06-08 01:39, Marcus Asteborg wrote:<br>
> 1. Build test for cmake and run the test in gitlab-ci.<br>
<br>
OK, merged.<br>
<br>
> 2. Disable the message box on Windows on abort that cause test hangs in CI.<br>
<br>
Merged too.<br>
<br>
> 3. Build time improvement by removing unnecessary includes of stdio.h<br>
> in production code and change to a lighter header intrin.h -><br>
> intrin0.h (windows only). Attached screenshot of measurement but it<br>
> resulted in 14% buildspeed compared to master on Windows 64 debug<br>
> builds on my setup. As most improvements comes from change intrin.h<br>
> the impact on other platforms will not be that much.<br>
<br>
I'm having a bit of an issue with the change to debug.h. I'm not sure <br>
exactly what you're trying to do, but the<br>
<br>
#ifdef HAVE_CONFIG_H<br>
#include "config.h"<br>
#endif<br>
<br>
should always be there (unconditionally) at the top of C files. Any <br>
reason you want to move an include before it and make it conditional?<br>
<br>
Cheers,<br>
<br>
Jean-Marc<br>
</div>
</span></font></div>
</body>
</html>