<div dir="ltr"><div>Hi Marcus,</div><div><br></div><div>Just letting you know that I've opened the PR, in case you don't get notified.</div><div><br></div><div>Regards,</div><div>Simon<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 14 Apr 2020 at 15:49, Marcus Asteborg <<a href="mailto:xnorpx@outlook.com">xnorpx@outlook.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Hi Simon,</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Please create a pull request here: <a href="https://github.com/xnorpx/opus/pulls" target="_blank">https://github.com/xnorpx/opus/pulls</a></div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Also please add a buildconfig here t<span style="font-family:Calibri,Helvetica,sans-serif;background-color:rgb(255,255,255);display:inline">hat exercise the BUILD_FRAMEWORK option</span>: <a href="https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml" id="gmail-m_-8681641976744514327LPlnk893442" target="_blank">https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml</a></div>
<div id="gmail-m_-8681641976744514327LPBorder_GTaHR0cHM6Ly9naXRodWIuY29tL3hub3JweC9vcHVzL2Jsb2IvbWFzdGVyLy5naXRodWIvd29ya2Zsb3dzL2J1aWxkLnltbA.." style="width:100%;margin-top:16px;margin-bottom:16px;max-width:800px;min-width:424px">
<table id="gmail-m_-8681641976744514327LPContainer793479" style="padding:12px 36px 12px 12px;width:100%;border-width:1px;border-style:solid;border-color:rgb(200,200,200);border-radius:2px">
<tbody>
<tr style="border-spacing:0px" valign="top">
<td>
<div id="gmail-m_-8681641976744514327LPImageContainer793479" style="margin-right:12px;height:160px;overflow:hidden">
<a id="gmail-m_-8681641976744514327LPImageAnchor793479" href="https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml" target="_blank"><img id="gmail-m_-8681641976744514327LPThumbnailImageId793479" alt="" style="display: block;" src="https://avatars2.githubusercontent.com/u/302709?s=400&v=4" width="160" height="160"></a></div>
</td>
<td style="width:100%">
<div id="gmail-m_-8681641976744514327LPTitle793479" style="font-size:21px;font-weight:300;margin-right:8px;font-family:wf_segoe-ui_light,"Segoe UI Light","Segoe WP Light","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;margin-bottom:12px">
<a id="gmail-m_-8681641976744514327LPUrlAnchor793479" href="https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml" style="text-decoration:none" target="_blank">xnorpx/opus</a></div>
<div id="gmail-m_-8681641976744514327LPDescription793479" style="font-size:14px;max-height:100px;color:rgb(102,102,102);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;margin-bottom:12px;margin-right:8px;overflow:hidden">
Modern audio compression for the internet. Contribute to xnorpx/opus development by creating an account on GitHub.</div>
<div id="gmail-m_-8681641976744514327LPMetadata793479" style="font-size:14px;font-weight:400;color:rgb(166,166,166);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif">
<a href="http://github.com" target="_blank">github.com</a></div>
</td>
</tr>
</tbody>
</table>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
That way we can ensure the patch work as expected and doesn't break any exciting behavior.</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Best Regards Marcus</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div id="gmail-m_-8681641976744514327appendonsend"></div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_-8681641976744514327divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Simon Jackson <<a href="mailto:simon.jackson@sonocent.com" target="_blank">simon.jackson@sonocent.com</a>><br>
<b>Sent:</b> Tuesday, April 14, 2020 02:12<br>
<b>To:</b> Marcus Asteborg <<a href="mailto:xnorpx@outlook.com" target="_blank">xnorpx@outlook.com</a>><br>
<b>Cc:</b> <a href="mailto:opus@xiph.org" target="_blank">opus@xiph.org</a> <<a href="mailto:opus@xiph.org" target="_blank">opus@xiph.org</a>><br>
<b>Subject:</b> Re: [opus] Opus CMake build support for Apple frameworks</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div>Hi Marcus,</div>
<div><br>
</div>
<div>When building shared libraries for macOS / iOS /tvOS, by default `.dylib` shared libraries will be generated. With this patch `BUILD_FRAMEWORK` is exposed as an option allowing the user to specify that a `.framework` bundle should be built instead of a
standalone `.dylib` file. Enabling the option sets the necessary target properties to instruct CMake to do this.<br>
<br>
</div>
<div>The Ogg CMake build already has this functionality, this patch should be consistent with how frameworks are handled there.<br>
</div>
<div><br>
</div>
<div>Simon<br>
</div>
</div>
<br>
<div>
<div dir="ltr">On Fri, 10 Apr 2020 at 18:32, Marcus Asteborg <<a href="mailto:xnorpx@outlook.com" target="_blank">xnorpx@outlook.com</a>> wrote:<br>
</div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="color:rgb(32,31,30);font-size:14.6667px;background-color:rgb(255,255,255);display:inline">Hi Simon,</span></div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="color:rgb(32,31,30);font-size:14.6667px;background-color:rgb(255,255,255);display:inline"><br>
</span></div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="color:rgb(32,31,30);font-size:14.6667px;background-color:rgb(255,255,255);display:inline">CMake 3.14 add support for crosscompiling iOS, tvOS and watchOS</span></div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="color:rgb(32,31,30);font-size:14.6667px;background-color:rgb(255,255,255);display:inline"><br>
</span></div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="color:rgb(32,31,30);font-size:14.6667px;background-color:rgb(255,255,255);display:inline"><a href="https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcmake.org%2Fcmake%2Fhelp%2Fv3.14%2Fmanual%2Fcmake-toolchains.7.html%23cross-compiling-for-ios-tvos-or-watchos&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564086078&sdata=0Bw0x9ZDBfsROuP4Dil7Fb4MPs29DQiV2Y%2F7V1j6zwE%3D&reserved=0" id="gmail-m_-8681641976744514327x_gmail-m_-4187382978205460496LPlnk950834" target="_blank">https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos</a></span></div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Can you clarify what your patch does?</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
//Marcus</div>
<div id="gmail-m_-8681641976744514327x_gmail-m_-4187382978205460496LPBorder_GTaHR0cHM6Ly9jbWFrZS5vcmcvY21ha2UvaGVscC92My4xNC9tYW51YWwvY21ha2UtdG9vbGNoYWlucy43Lmh0bWwjY3Jvc3MtY29tcGlsaW5nLWZvci1pb3MtdHZvcy1vci13YXRjaG9z" style="width:100%;margin-top:16px;margin-bottom:16px;max-width:800px;min-width:424px">
<table id="gmail-m_-8681641976744514327x_gmail-m_-4187382978205460496LPContainer393790" style="padding:12px 36px 12px 12px;width:100%;border-width:1px;border-style:solid;border-color:rgb(200,200,200);border-radius:2px">
<tbody>
<tr style="border-spacing:0px" valign="top">
<td style="width:100%">
<div id="gmail-m_-8681641976744514327x_gmail-m_-4187382978205460496LPTitle393790" style="font-size:21px;font-weight:300;margin-right:8px;font-family:wf_segoe-ui_light,"Segoe UI Light","Segoe WP Light","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;margin-bottom:12px">
<a id="gmail-m_-8681641976744514327x_gmail-m_-4187382978205460496LPUrlAnchor393790" href="https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcmake.org%2Fcmake%2Fhelp%2Fv3.14%2Fmanual%2Fcmake-toolchains.7.html%23cross-compiling-for-ios-tvos-or-watchos&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564096059&sdata=s85t4wULfxV5mLOcheTvhV%2Bel%2BQd1uZlr5kF0z9WyCw%3D&reserved=0" style="text-decoration:none" target="_blank">cmake-toolchains(7)
— CMake 3.14.7 Documentation</a></div>
<div id="gmail-m_-8681641976744514327x_gmail-m_-4187382978205460496LPDescription393790" style="font-size:14px;max-height:100px;color:rgb(102,102,102);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;margin-bottom:12px;margin-right:8px;overflow:hidden">
The CMAKE_SYSTEM_NAME is the CMake-identifier of the target platform to build for.. The CMAKE_SYSTEM_PROCESSOR is the CMake-identifier of the target architecture to build for.. The CMAKE_SYSROOT is optional, and may be specified if a sysroot is available..
The CMAKE_STAGING_PREFIX is also optional. It may be used to specify a path on the host to install to. The CMAKE_INSTALL_PREFIX is always ...</div>
<div id="gmail-m_-8681641976744514327x_gmail-m_-4187382978205460496LPMetadata393790" style="font-size:14px;font-weight:400;color:rgb(166,166,166);font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif">
<a href="https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcmake.org%2F&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564106041&sdata=34JR5LY1Gpsbx2TE9jBB1OcnAYo6BSrRE3VQ4aomiyE%3D&reserved=0" target="_blank">cmake.org</a></div>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<div id="gmail-m_-8681641976744514327x_gmail-m_-4187382978205460496appendonsend"></div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_-8681641976744514327x_gmail-m_-4187382978205460496divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> opus <<a href="mailto:opus-bounces@xiph.org" target="_blank">opus-bounces@xiph.org</a>> on behalf of
<a href="mailto:opus-request@xiph.org" target="_blank">opus-request@xiph.org</a> <<a href="mailto:opus-request@xiph.org" target="_blank">opus-request@xiph.org</a>><br>
<b>Sent:</b> Friday, April 10, 2020 05:00<br>
<b>To:</b> <a href="mailto:opus@xiph.org" target="_blank">opus@xiph.org</a> <<a href="mailto:opus@xiph.org" target="_blank">opus@xiph.org</a>><br>
<b>Subject:</b> opus Digest, Vol 132, Issue 5</font>
<div> </div>
</div>
<div><font size="2"><span style="font-size:11pt">
<div>Send opus mailing list submissions to<br>
<a href="mailto:opus@xiph.org" target="_blank">opus@xiph.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564116025&sdata=KqIRU3pSXaanAqPMb7A8fGwp9k9q77o%2FHL6hRreFrRM%3D&reserved=0" target="_blank">
https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=bYVdG80m0eaYyGgYyrclvfFOXjJicH2525zzf62HtNY%3D&reserved=0</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:opus-request@xiph.org" target="_blank">opus-request@xiph.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:opus-owner@xiph.org" target="_blank">opus-owner@xiph.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of opus digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. Opus CMake build support for Apple frameworks (Simon Jackson)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Thu, 9 Apr 2020 16:59:54 +0100<br>
From: Simon Jackson <<a href="mailto:simon.jackson@sonocent.com" target="_blank">simon.jackson@sonocent.com</a>><br>
To: <a href="mailto:opus@xiph.org" target="_blank">opus@xiph.org</a><br>
Subject: [opus] Opus CMake build support for Apple frameworks<br>
Message-ID:<br>
<CAAZh+M2BzPMvB6=<a href="mailto:U-LcAOZmSK_1phySrTRWGG9UhcMDWjf5Txw@mail.gmail.com" target="_blank">U-LcAOZmSK_1phySrTRWGG9UhcMDWjf5Txw@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
Hi,<br>
<br>
I've put together a patch which adds support to the CMake build for<br>
building Apple frameworks, as much as I dislike them. Is this something<br>
you'd like to integrate?<br>
<br>
Thanks,<br>
Simon<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.html&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564126005&sdata=uNJ7JiprmEUTKx6Ef0ho1bmDyo5f0iZ2Y7xgjMWznyA%3D&reserved=0" target="_blank">https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.html&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=nIeHaWLowLksYl9QQvV1y2Rkd3zvUGiuqfIUYHknHnw%3D&reserved=0</a>><br>
-------------- next part --------------<br>
A non-text attachment was scrubbed...<br>
Name: opus_cmake_frameworks.patch<br>
Type: application/octet-stream<br>
Size: 2793 bytes<br>
Desc: not available<br>
URL: <<a href="https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.obj&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564135989&sdata=bu2Z4FXmEOoSMxIKjjRDeAr6FULDJhslK4JBMZfT3KI%3D&reserved=0" target="_blank">https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fpipermail%2Fopus%2Fattachments%2F20200409%2Fa281ca94%2Fattachment-0001.obj&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=d5V%2BTOGF3Onv6FJiFXlksuCLdf2Q5XKhqpQ8VsANw%2BU%3D&reserved=0</a>><br>
<br>
------------------------------<br>
<br>
Subject: Digest Footer<br>
<br>
_______________________________________________<br>
opus mailing list<br>
<a href="mailto:opus@xiph.org" target="_blank">opus@xiph.org</a><br>
<a href="https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564145971&sdata=Vq2Ip5UFH3ugg3XEe2pXWYadL%2FuurVAD2bLjpbyk1gI%3D&reserved=0" target="_blank">https://eur05.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C5129a9bc55174fda492008d7dd46b6df%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637221168091429699&sdata=bYVdG80m0eaYyGgYyrclvfFOXjJicH2525zzf62HtNY%3D&reserved=0</a><br>
<br>
<br>
------------------------------<br>
<br>
End of opus Digest, Vol 132, Issue 5<br>
************************************<br>
</div>
</span></font></div>
</div>
_______________________________________________<br>
opus mailing list<br>
<a href="mailto:opus@xiph.org" target="_blank">opus@xiph.org</a><br>
<a href="https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C31d2ce47ca2441fc84a108d7e053f83f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637224523564160945&sdata=mvb6hWdBK5H%2B2gpxNgV6LosVH6wGGSPR5TPK%2F4bEprg%3D&reserved=0" rel="noreferrer" target="_blank">http://lists.xiph.org/mailman/listinfo/opus</a><br>
</blockquote>
</div>
</div>
</div>
</blockquote></div>