<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span>Hi,</span></div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span><br>
</span></div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span>Thanks for the feedback, attached is patch with default buildtype set to release.</span></div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span><br>
</span></div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span>Also fixed the issues Mark pointed out especially CUSTOM_MODES was a bug that has been fixed and added custom_demo as a program when this is enabled.</span></div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span><br>
</span></div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span>For setting CFLAGS see the following:</span></div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span><br>
</span></div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span><a id="LPlnk800221" href="https://stackoverflow.com/questions/10085945/set-cflags-and-cxxflags-options-using-cmake">https://stackoverflow.com/questions/10085945/set-cflags-and-cxxflags-options-using-cmake</a></span><span><br>
</span></div>
<div class="LPBorder321202" id="LPBorder_GTaHR0cHM6Ly9zdGFja292ZXJmbG93LmNvbS9xdWVzdGlvbnMvMTAwODU5NDUvc2V0LWNmbGFncy1hbmQtY3h4ZmxhZ3Mtb3B0aW9ucy11c2luZy1jbWFrZQ.." style="width: 100%; margin-top: 16px; margin-bottom: 16px; position: relative; min-width: 424px; max-width: 800px;" contenteditable="false">
<table id="LPContainer321202" role="presentation" style="padding: 12px 36px 12px 12px; border-radius: 2px; border: 1px solid rgb(200, 200, 200); width: 100%;">
<tbody>
<tr valign="top" style="border-spacing: 0px;">
<td>
<div id="LPImageContainer321202" style="height: 160px; overflow: hidden; margin-right: 12px; position: relative;">
<a id="LPImageAnchor321202" href="https://stackoverflow.com/questions/10085945/set-cflags-and-cxxflags-options-using-cmake" target="_blank"><img width="160" height="160" id="LPThumbnailImageId321202" style="display: block;" alt="" src="https://cdn.sstatic.net/Sites/stackoverflow/img/apple-touch-icon@2.png?v=73d79a89bded"></a></div>
</td>
<td style="width: 100%;">
<div id="LPTitle321202" style="font-family: "wf_segoe-ui_light","Segoe UI Light","Segoe WP Light","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif; font-size: 21px; font-weight: 300; margin-right: 8px; margin-bottom: 12px;">
<a id="LPUrlAnchor321202" style="color: var(--themePrimary); text-decoration: none;" href="https://stackoverflow.com/questions/10085945/set-cflags-and-cxxflags-options-using-cmake" target="_blank">Set CFLAGS and CXXFLAGS options using CMake - Stack Overflow</a></div>
<div id="LPDescription321202" style="color: rgb(102, 102, 102); overflow: hidden; font-family: "wf_segoe-ui_normal","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif; font-size: 14px; margin-right: 8px; margin-bottom: 12px; max-height: 100px;">
If you want a debuggable build, just do a debug configure at the command line. "cmake -DCMAKE_BUILD_TYPE=Debug". The resulting build will have the debug flags on for the given build system.</div>
<div id="LPMetadata321202" style="color: rgb(166, 166, 166); font-family: "wf_segoe-ui_normal","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif; font-size: 14px; font-weight: 400;">
stackoverflow.com</div>
</td>
</tr>
</tbody>
</table>
</div>
<div><span style="display: inline !important; background-color: rgb(239, 240, 241); color: rgb(36, 39, 41); font-family: Consolas,Menlo,Monaco,Lucida Console,Liberation Mono,DejaVu Sans Mono,Bitstream Vera Sans Mono,Courier New,monospace,sans-serif; font-size: 13px; font-size-adjust: none">export
CFLAGS=-ggdb </span></div>
<div><span style="display: inline !important; background-color: rgb(239, 240, 241); color: rgb(36, 39, 41); font-family: Consolas,Menlo,Monaco,Lucida Console,Liberation Mono,DejaVu Sans Mono,Bitstream Vera Sans Mono,Courier New,monospace,sans-serif; font-size: 13px; font-size-adjust: none">export
CXXFLAGS=-ggdb</span></div>
<div><br>
</div>
<div><a id="LPlnk524142" href="https://github.com/xiph/opus/pull/117">https://github.com/xiph/opus/pull/117</a></div>
<div class="LPBorder839748" id="LPBorder_GTaHR0cHM6Ly9naXRodWIuY29tL3hpcGgvb3B1cy9wdWxsLzExNw.." style="width: 100%; margin-top: 16px; margin-bottom: 16px; position: relative; min-width: 424px; max-width: 800px;" contenteditable="false">
<table id="LPContainer839748" role="presentation" style="padding: 12px 36px 12px 12px; border-radius: 2px; border: 1px solid rgb(200, 200, 200); width: 100%;">
<tbody>
<tr valign="top" style="border-spacing: 0px;">
<td>
<div id="LPImageContainer839748" style="height: 160px; overflow: hidden; margin-right: 12px; position: relative;">
<a id="LPImageAnchor839748" href="https://github.com/xiph/opus/pull/117" target="_blank"><img width="160" height="160" id="LPThumbnailImageId839748" style="display: block;" alt="" src="https://avatars0.githubusercontent.com/u/8365509?s=400&v=4"></a></div>
</td>
<td style="width: 100%;">
<div id="LPTitle839748" style="font-family: "wf_segoe-ui_light","Segoe UI Light","Segoe WP Light","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif; font-size: 21px; font-weight: 300; margin-right: 8px; margin-bottom: 12px;">
<a id="LPUrlAnchor839748" style="color: var(--themePrimary); text-decoration: none;" href="https://github.com/xiph/opus/pull/117" target="_blank">CMake changes - Make release build default, made CUSTOM_MODE an optio… by xnorpx · Pull Request #117 · xiph/opus</a></div>
<div id="LPDescription839748" style="color: rgb(102, 102, 102); overflow: hidden; font-family: "wf_segoe-ui_normal","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif; font-size: 14px; margin-right: 8px; margin-bottom: 12px; max-height: 100px;">
CMake changes - Make release build default, made CUSTOM_MODE an option with default off and added missing buildflags for Linux and security.</div>
<div id="LPMetadata839748" style="color: rgb(166, 166, 166); font-family: "wf_segoe-ui_normal","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif; font-size: 14px; font-weight: 400;">
github.com</div>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<div><span><br>
</span></div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span>//Marcus</span></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Jean-Marc Valin <jmvalin@jmvalin.ca><br>
<b>Sent:</b> Wednesday, April 10, 2019 14:52<br>
<b>To:</b> Marcus Asteborg; opus@xiph.org<br>
<b>Subject:</b> Re: [opus] CMake support for Opus proposal (in addition to Autotools)</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi,<br>
<br>
It looks like cmake currently defaults to no optimization, which I think<br>
is a bit unexpected for most users. I don't know how to do that in<br>
cmake, but it would be good to default to a "release" build with<br>
optimizations. Can you have a patch to do that?<br>
<br>
Also, is there a way to manually add flags to the compiler (like setting<br>
CFLAGS with autotools)?<br>
<br>
Cheers,<br>
<br>
Jean-Marc<br>
<br>
On 04/02/2019 07:15 PM, Marcus Asteborg wrote:<br>
> Right that I had completely missed, I have added the files and verified<br>
> that it builds with CMake from the tar on Linux (out of the git repo)<br>
> <br>
> I am parsing the package_version file from the tarball if it exists so<br>
> it should maintain the version info.<br>
> <br>
> //Marcus<br>
> <br>
> <br>
> ------------------------------------------------------------------------<br>
> *From:* Jean-Marc Valin <jmvalin@jmvalin.ca><br>
> *Sent:* Tuesday, April 2, 2019 11:38<br>
> *To:* Marcus Asteborg; opus@xiph.org<br>
> *Subject:* Re: [opus] CMake support for Opus proposal (in addition to<br>
> Autotools)<br>
> <br>
> Thanks, it applies now. I think you'd also want to add some (all?) of<br>
> these files to EXTRA_DIST in Makefile.am, otherwise your cmake files<br>
> won't be included in release tarballs, which are generate using "make<br>
> dist". To test, you should try running run "make dist" to generate a<br>
> tarball yourself. From there, you try building the contents with your<br>
> cmake files and see if it works.<br>
> <br>
> Cheers,<br>
> <br>
> Jean-Marc<br>
> <br>
> On 04/02/2019 11:26 AM, Marcus Asteborg wrote:<br>
>> Hi,<br>
>> <br>
>> Thanks for the quick feedback I have changed the name to avoid conflict.<br>
>> <br>
>> Attached is the updated patch.<br>
>> <br>
>> //Marcus<br>
>> ------------------------------------------------------------------------<br>
>> *From:* Jean-Marc Valin <jmvalin@jmvalin.ca><br>
>> *Sent:* Tuesday, April 2, 2019 00:07<br>
>> *To:* Marcus Asteborg; opus@xiph.org<br>
>> *Subject:* Re: [opus] CMake support for Opus proposal (in addition to<br>
>> Autotools)<br>
>> <br>
>> Hi Marcus,<br>
>> <br>
>> There seems to be a conflict between the autotools-created config.h.in<br>
>> and the same file added by your patch. Any way you can use use a<br>
>> different name?<br>
>> <br>
>> Cheers,<br>
>> <br>
>> Jean-Marc<br>
>> <br>
>> On 04/02/2019 01:39 AM, Marcus Asteborg wrote:<br>
>>> Hi,<br>
>>> <br>
>>> <br>
>>> Here is a proposal for adding CMake in addition of Autotools.<br>
>>> <br>
>>> <br>
>>> See the attached patch for changes or the pull request here:<br>
>>> <a href="https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639197576&sdata=sV5Oy0hrlLtp558MUVMMixMG5IJ7oN91JndXbqcSX8M%3D&reserved=0">
https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639197576&sdata=sV5Oy0hrlLtp558MUVMMixMG5IJ7oN91JndXbqcSX8M%3D&reserved=0</a><br>
>>> <<a href="https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639197576&sdata=sV5Oy0hrlLtp558MUVMMixMG5IJ7oN91JndXbqcSX8M%3D&reserved=0">https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639197576&sdata=sV5Oy0hrlLtp558MUVMMixMG5IJ7oN91JndXbqcSX8M%3D&reserved=0</a>><br>
>>> <br>
>>> <br>
>>> The CMake scripts are parsing the filelist from Autotools, so only one<br>
>>> file list needs to be maintained.<br>
>>> <br>
>>> <br>
>>> With this change the checked in Visual Studio solution can be removed<br>
>>> and no longer need to be maintained and updated when Visual Studio is<br>
>>> updated.<br>
>>> <br>
>>> <br>
>>> For related discussion about CMake support see<br>
>>> <a href="https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639197576&sdata=LB2DZZTnqoy8WmhrVX%2F05ZhxJe2MfayOrega2jrHV6c%3D&reserved=0">
https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639197576&sdata=LB2DZZTnqoy8WmhrVX%2F05ZhxJe2MfayOrega2jrHV6c%3D&reserved=0</a><br>
>> <<a href="https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639207584&sdata=A2KqC8trMHYgr9hRolbQiQHrma6sTx4RhtJb7eA6Eu8%3D&reserved=0">https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639207584&sdata=A2KqC8trMHYgr9hRolbQiQHrma6sTx4RhtJb7eA6Eu8%3D&reserved=0</a>><br>
>>> <br>
>>> <br>
>>> For any concerns, comments or questions regarding the change please<br>
>>> comment in the pull request, reply to this thread or send me an e-mail.<br>
>>> <br>
>>> <br>
>>> Related Issue:<br>
>>> <br>
>>> <a href="https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639207584&sdata=tl5TJEQTx1LaRrVZ0HhUPhKyZcPIQdSj2p0uYgMUjEw%3D&reserved=0">
https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639207584&sdata=tl5TJEQTx1LaRrVZ0HhUPhKyZcPIQdSj2p0uYgMUjEw%3D&reserved=0</a><br>
>>> <<a href="https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639207584&sdata=tl5TJEQTx1LaRrVZ0HhUPhKyZcPIQdSj2p0uYgMUjEw%3D&reserved=0">https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639207584&sdata=tl5TJEQTx1LaRrVZ0HhUPhKyZcPIQdSj2p0uYgMUjEw%3D&reserved=0</a>><br>
>>> <br>
>>> <br>
>>> //Marcus<br>
>>> <br>
>>> <br>
>>> <br>
>>> <br>
>>> _______________________________________________<br>
>>> opus mailing list<br>
>>> opus@xiph.org<br>
>>> <a href="https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639207584&sdata=w3BgyhzEKP7WhsnNiaVE02mJZ5JEuj6SKe6rU6EG3y0%3D&reserved=0">
https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7Cfbf5c4691fe9442ae77108d6bdfedbfe%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636905299639207584&sdata=w3BgyhzEKP7WhsnNiaVE02mJZ5JEuj6SKe6rU6EG3y0%3D&reserved=0</a><br>
>>> <br>
</div>
</span></font></div>
</body>
</html>