<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
Right that I had completely missed, I have added the files and verified that it builds with CMake from the tar on Linux (out of the git repo)</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<br>
</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
I am parsing the package_version file from the tarball if it exists so it should maintain the version info.</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<br>
</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
//Marcus</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span><br>
</span></div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<span><br>
</span></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Jean-Marc Valin <jmvalin@jmvalin.ca><br>
<b>Sent:</b> Tuesday, April 2, 2019 11:38<br>
<b>To:</b> Marcus Asteborg; opus@xiph.org<br>
<b>Subject:</b> Re: [opus] CMake support for Opus proposal (in addition to Autotools)</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Thanks, it applies now. I think you'd also want to add some (all?) of<br>
these files to EXTRA_DIST in Makefile.am, otherwise your cmake files<br>
won't be included in release tarballs, which are generate using "make<br>
dist". To test, you should try running run "make dist" to generate a<br>
tarball yourself. From there, you try building the contents with your<br>
cmake files and see if it works.<br>
<br>
Cheers,<br>
<br>
Jean-Marc<br>
<br>
On 04/02/2019 11:26 AM, Marcus Asteborg wrote:<br>
> Hi,<br>
> <br>
> Thanks for the quick feedback I have changed the name to avoid conflict.<br>
> <br>
> Attached is the updated patch.<br>
> <br>
> //Marcus<br>
> ------------------------------------------------------------------------<br>
> *From:* Jean-Marc Valin <jmvalin@jmvalin.ca><br>
> *Sent:* Tuesday, April 2, 2019 00:07<br>
> *To:* Marcus Asteborg; opus@xiph.org<br>
> *Subject:* Re: [opus] CMake support for Opus proposal (in addition to<br>
> Autotools)<br>
> <br>
> Hi Marcus,<br>
> <br>
> There seems to be a conflict between the autotools-created config.h.in<br>
> and the same file added by your patch. Any way you can use use a<br>
> different name?<br>
> <br>
> Cheers,<br>
> <br>
> Jean-Marc<br>
> <br>
> On 04/02/2019 01:39 AM, Marcus Asteborg wrote:<br>
>> Hi,<br>
>> <br>
>> <br>
>> Here is a proposal for adding CMake in addition of Autotools.<br>
>> <br>
>> <br>
>> See the attached patch for changes or the pull request here:<br>
>> <a href="https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884177946&sdata=Ed139jcES0woXrPabecRjGq7vGrnvpZJkRBQ8ty86Ys%3D&reserved=0">
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884177946&sdata=Ed139jcES0woXrPabecRjGq7vGrnvpZJkRBQ8ty86Ys%3D&reserved=0</a><br>
>> <<a href="https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884187957&sdata=a50Uz9L4XicAFm82I0J1RvorD42Bg9SXxMxIGmSpJSw%3D&reserved=0">https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884187957&sdata=a50Uz9L4XicAFm82I0J1RvorD42Bg9SXxMxIGmSpJSw%3D&reserved=0</a>><br>
>> <br>
>> <br>
>> The CMake scripts are parsing the filelist from Autotools, so only one<br>
>> file list needs to be maintained.<br>
>> <br>
>> <br>
>> With this change the checked in Visual Studio solution can be removed<br>
>> and no longer need to be maintained and updated when Visual Studio is<br>
>> updated.<br>
>> <br>
>> <br>
>> For related discussion about CMake support see<br>
>> <a href="https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884187957&sdata=5IvhQfm5HjZZYF9eOfapg7VH7X0AWLcXnCyYmJYG848%3D&reserved=0">
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884187957&sdata=5IvhQfm5HjZZYF9eOfapg7VH7X0AWLcXnCyYmJYG848%3D&reserved=0</a><br>
> <<a href="https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884187957&sdata=5IvhQfm5HjZZYF9eOfapg7VH7X0AWLcXnCyYmJYG848%3D&reserved=0">https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884187957&sdata=5IvhQfm5HjZZYF9eOfapg7VH7X0AWLcXnCyYmJYG848%3D&reserved=0</a>><br>
>> <br>
>> <br>
>> For any concerns, comments or questions regarding the change please<br>
>> comment in the pull request, reply to this thread or send me an e-mail.<br>
>> <br>
>> <br>
>> Related Issue:<br>
>> <br>
>> <a href="https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884187957&sdata=z2POz2d0rUDPwTSMov7BD6qQyUl25cRCBIRJpzsK8d4%3D&reserved=0">
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884187957&sdata=z2POz2d0rUDPwTSMov7BD6qQyUl25cRCBIRJpzsK8d4%3D&reserved=0</a><br>
>> <<a href="https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884187957&sdata=z2POz2d0rUDPwTSMov7BD6qQyUl25cRCBIRJpzsK8d4%3D&reserved=0">https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884187957&sdata=z2POz2d0rUDPwTSMov7BD6qQyUl25cRCBIRJpzsK8d4%3D&reserved=0</a>><br>
>> <br>
>> <br>
>> //Marcus<br>
>> <br>
>> <br>
>> <br>
>> <br>
>> _______________________________________________<br>
>> opus mailing list<br>
>> opus@xiph.org<br>
>> <a href="https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884197962&sdata=szVFXlIfbQD%2FL6OMWEonuysnYQo46vSjJ%2FcIgh2ahsc%3D&reserved=0">
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C83448751302e4bd85a8908d6b79a58ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636898270884197962&sdata=szVFXlIfbQD%2FL6OMWEonuysnYQo46vSjJ%2FcIgh2ahsc%3D&reserved=0</a><br>
>> <br>
</div>
</span></font></div>
</body>
</html>