<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
Hi,</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<br>
</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
Thanks for the quick feedback I have changed the name to avoid conflict.</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<br>
</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
Attached is the updated patch.</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
<br>
</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;">
//Marcus</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Jean-Marc Valin <jmvalin@jmvalin.ca><br>
<b>Sent:</b> Tuesday, April 2, 2019 00:07<br>
<b>To:</b> Marcus Asteborg; opus@xiph.org<br>
<b>Subject:</b> Re: [opus] CMake support for Opus proposal (in addition to Autotools)</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi Marcus,<br>
<br>
There seems to be a conflict between the autotools-created config.h.in<br>
and the same file added by your patch. Any way you can use use a<br>
different name?<br>
<br>
Cheers,<br>
<br>
Jean-Marc<br>
<br>
On 04/02/2019 01:39 AM, Marcus Asteborg wrote:<br>
> Hi,<br>
> <br>
> <br>
> Here is a proposal for adding CMake in addition of Autotools.<br>
> <br>
> <br>
> See the attached patch for changes or the pull request here:<br>
> <a href="https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328827874&sdata=ulSL9eGKj8cVt6VPufmkod061Ii56r%2FAsFXvOjyWu44%3D&reserved=0">
https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328827874&sdata=ulSL9eGKj8cVt6VPufmkod061Ii56r%2FAsFXvOjyWu44%3D&reserved=0</a><br>
> <<a href="https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328827874&sdata=ulSL9eGKj8cVt6VPufmkod061Ii56r%2FAsFXvOjyWu44%3D&reserved=0">https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F100&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328827874&sdata=ulSL9eGKj8cVt6VPufmkod061Ii56r%2FAsFXvOjyWu44%3D&reserved=0</a>><br>
> <br>
> <br>
> The CMake scripts are parsing the filelist from Autotools, so only one<br>
> file list needs to be maintained.<br>
> <br>
> <br>
> With this change the checked in Visual Studio solution can be removed<br>
> and no longer need to be maintained and updated when Visual Studio is<br>
> updated.<br>
> <br>
> <br>
> For related discussion about CMake support see<br>
> <a href="https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328827874&sdata=t1IJUHKLyyDpGWzyi8A6dozfmFDZalgHs8Ds%2Bnlf9Qc%3D&reserved=0">
https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328827874&sdata=t1IJUHKLyyDpGWzyi8A6dozfmFDZalgHs8Ds%2Bnlf9Qc%3D&reserved=0</a>
<<a href="https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328827874&sdata=t1IJUHKLyyDpGWzyi8A6dozfmFDZalgHs8Ds%2Bnlf9Qc%3D&reserved=0">https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fpull%2F37&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328827874&sdata=t1IJUHKLyyDpGWzyi8A6dozfmFDZalgHs8Ds%2Bnlf9Qc%3D&reserved=0</a>><br>
> <br>
> <br>
> For any concerns, comments or questions regarding the change please<br>
> comment in the pull request, reply to this thread or send me an e-mail.<br>
> <br>
> <br>
> Related Issue:<br>
> <br>
> <a href="https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328827874&sdata=MUh7c1xua91%2Bvn8M33fbsTKS8%2FZeyZV02BorkANy6h4%3D&reserved=0">
https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328827874&sdata=MUh7c1xua91%2Bvn8M33fbsTKS8%2FZeyZV02BorkANy6h4%3D&reserved=0</a><br>
> <<a href="https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328837885&sdata=rQA6M3kf87Zd%2Bc3IBVExdUWj8zKYMIzfTAePmrXDnwo%3D&reserved=0">https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxiph%2Fopus%2Fissues%2F85&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328837885&sdata=rQA6M3kf87Zd%2Bc3IBVExdUWj8zKYMIzfTAePmrXDnwo%3D&reserved=0</a>><br>
> <br>
> <br>
> //Marcus<br>
> <br>
> <br>
> <br>
> <br>
> _______________________________________________<br>
> opus mailing list<br>
> opus@xiph.org<br>
> <a href="https://nam01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328837885&sdata=xTw1jcE0ABlREHtDX5ycQXcrYnzQijLEWJ2LZk6JPEk%3D&reserved=0">
https://nam01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C47f897fd8d6e42c8336c08d6b739d457%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636897856328837885&sdata=xTw1jcE0ABlREHtDX5ycQXcrYnzQijLEWJ2LZk6JPEk%3D&reserved=0</a><br>
> <br>
</div>
</span></font></div>
</body>
</html>