<div dir="ltr">Hi Ulrich,<div><br></div><div>Thanks for checking the patch.</div><div><br></div><div>The entire declarations of the functions are like this:</div><div><br></div><div><div><font face="monospace, monospace">void silk_NSQ_del_dec_c(</font></div><div><font face="monospace, monospace"> const silk_encoder_state *psEncC, /* I/O Encoder State */</font></div><div><font face="monospace, monospace"> silk_nsq_state *NSQ, /* I/O NSQ state */</font></div><div><font face="monospace, monospace"> SideInfoIndices *psIndices, /* I/O Quantization Indices */</font></div><div><font face="monospace, monospace"> const opus_int16 x16[], /* I Input */</font></div><div><font face="monospace, monospace"> opus_int8 pulses[], /* O Quantized pulse signal */</font></div><div><font face="monospace, monospace"> const opus_int16 PredCoef_Q12[ 2 * MAX_LPC_ORDER ], /* I Short term prediction coefs */</font></div><div><font face="monospace, monospace"> const opus_int16 LTPCoef_Q14[ LTP_ORDER * MAX_NB_SUBFR ], /* I Long term prediction coefs */</font></div><div><font face="monospace, monospace"> const opus_int16 AR_Q13[ MAX_NB_SUBFR * MAX_SHAPE_LPC_ORDER ], /* I Noise shaping coefs */</font></div><div><font face="monospace, monospace"> const opus_int HarmShapeGain_Q14[ MAX_NB_SUBFR ], /* I Long term shaping coefs */</font></div><div><font face="monospace, monospace"> const opus_int Tilt_Q14[ MAX_NB_SUBFR ], /* I Spectral tilt */</font></div><div><font face="monospace, monospace"> const opus_int32 LF_shp_Q14[ MAX_NB_SUBFR ], /* I Low frequency shaping coefs */</font></div><div><font face="monospace, monospace"> const opus_int32 Gains_Q16[ MAX_NB_SUBFR ], /* I Quantization step sizes */</font></div><div><font face="monospace, monospace"> const opus_int pitchL[ MAX_NB_SUBFR ], /* I Pitch lags */</font></div><div><font face="monospace, monospace"> const opus_int Lambda_Q10, /* I Rate/distortion tradeoff */</font></div><div><font face="monospace, monospace"> const opus_int LTP_scale_Q14 /* I LTP state scaling */</font></div><div><font face="monospace, monospace">)</font></div></div><div><br></div><div>So the comments are trying to indent to the longest argument <span style="font-family:monospace,monospace">AR_Q13[ MAX_NB_SUBFR * MAX_SHAPE_LPC_ORDER ]</span>, though still failed by 2 white spaces.</div><div><br></div><div>This patch only focuses on the I/O comments correction, so we didn't touch the indention issue.</div><div><br></div><div>Thanks,</div><div>Linfeng</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 19, 2017 at 11:54 PM, Ulrich Windl <span dir="ltr"><<a href="mailto:Ulrich.Windl@rz.uni-regensburg.de" target="_blank">Ulrich.Windl@rz.uni-regensburg.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi!<br>
<br>
While talking on cosmetics: I noticed that a few lines significantly exceed the 80-column limit without obvious need. See attachment for an example.<br>
<br>
Regards,<br>
Ulrich<br>
<br>
>>> Linfeng Zhang <<a href="mailto:linfengz@google.com">linfengz@google.com</a>> schrieb am 19.04.2017 um 18:49 in Nachricht<br>
<CAKoqLCA-<wbr>tXd7XSa0a1T9xE4SF9GPMp+<wbr>ySxsULgbB_F_=<a href="mailto:3dK3iw@mail.gmail.com">3dK3iw@mail.<wbr>gmail.com</a>>:<br>
<div class="HOEnZb"><div class="h5">> Hi,<br>
><br>
> Attached is a patch for cosmetics purpose. Please review.<br>
><br>
> Thanks,<br>
> Linfeng Zhang<br>
<br>
<br>
<br>
<br>
</div></div></blockquote></div><br></div>