<div dir="ltr">Hi Timothy,<div><br></div><div>Could you please share your make configuration?</div><div><br></div><div>I tested on this morning's master with my first 2 patches with the following configurations and all work fine.</div><div><br></div><div><table cellspacing="0" cellpadding="0" dir="ltr" border="1" style="table-layout:fixed;font-size:13px;font-family:arial,sans,sans-serif;border-collapse:collapse;border:1px solid rgb(204,204,204)"><colgroup><col width="241"><col width="185"><col width="127"><col width="129"><col width="63"><col width="79"></colgroup><tbody><tr style="height:21px"><td style="padding:2px 3px;vertical-align:bottom;font-weight:bold">ARM Fixed-point</td><td style="padding:2px 3px;vertical-align:bottom;word-wrap:break-word" rowspan="1" colspan="5">./configure --build x86_64-unknown-linux-gnu --host arm-linux-gnueabihf --enable-fixed-point --enable-intrinsics CFLAGS='-O3' --disable-shared</td></tr><tr style="height:21px"><td style="padding:2px 3px;vertical-align:bottom;font-weight:bold">ARM Floating-Point:</td><td style="padding:2px 3px;vertical-align:bottom;font-family:arial;word-wrap:break-word" rowspan="1" colspan="5">./configure --build x86_64-unknown-linux-gnu --host arm-linux-gnueabihf --enable-intrinsics CFLAGS='-O3' --disable-shared</td></tr><tr style="height:21px"><td style="padding:2px 3px;vertical-align:bottom;font-weight:bold">X86 Fixed-Point:</td><td style="padding:2px 3px;vertical-align:bottom;font-family:arial;word-wrap:break-word" rowspan="1" colspan="5">./configure --enable-fixed-point --enable-intrinsics CFLAGS='-O3' --disable-shared</td></tr><tr style="height:21px"><td style="padding:2px 3px;vertical-align:bottom;font-weight:bold">X86 Floating-Point:</td><td style="padding:2px 3px;vertical-align:bottom;font-family:arial;word-wrap:break-word" rowspan="1" colspan="5">./configure --enable-intrinsics CFLAGS='-O3' --disable-shared</td></tr></tbody></table></div><div><br></div><div>Thanks,</div><div>Linfeng</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 4, 2016 at 7:31 AM, Timothy B. Terriberry <span dir="ltr"><<a href="mailto:tterribe@xiph.org" target="_blank">tterribe@xiph.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Linfeng Zhang wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Created corresponding unit test, and the optimization is bit exact with C<br>
function.<br>
</blockquote>
<br></span>
How are you building/running these tests? None of the tests (from any of the patches starting with the second) build for me on 32-bit ARMv7 with --enable-fixed-point, or even on x86. Example errors:<br>
<br>
  CCLD     tests/test_unit_optimization<br>
tests/test_unit_optimization.o<wbr>: In function `test_fir':<br>
/home/derf/src/xiph/git/xiph/o<wbr>pus/build/../celt/tests/test_u<wbr>nit_optimization_lpc.c:58: undefined reference to `CELT_FIR_IMPL'<br>
/home/derf/src/xiph/git/xiph/o<wbr>pus/build/../celt/tests/test_u<wbr>nit_optimization_lpc.c:65: undefined reference to `CELT_FIR_IMPL'<br>
/home/derf/src/xiph/git/xiph/o<wbr>pus/build/../celt/tests/test_u<wbr>nit_optimization_lpc.c:77: undefined reference to `celt_fir_c'<br>
tests/test_unit_optimization.o<wbr>: In function `main':<br>
/home/derf/src/xiph/git/xiph/o<wbr>pus/build/../tests/test_unit_o<wbr>ptimization.c:51: undefined reference to `opus_select_arch'<br>
collect2: error: ld returned 1 exit status<br>
<br>
______________________________<wbr>_________________<br>
opus mailing list<br>
<a href="mailto:opus@xiph.org" target="_blank">opus@xiph.org</a><br>
<a href="http://lists.xiph.org/mailman/listinfo/opus" rel="noreferrer" target="_blank">http://lists.xiph.org/mailman/<wbr>listinfo/opus</a><br>
</blockquote></div><br></div>