On Thu, Nov 29, 2012 at 2:52 PM, Ralph Giles <span dir="ltr"><<a href="mailto:giles@thaumas.net" target="_blank">giles@thaumas.net</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Also, the opus.h wrapper in<br>
<a href="http://src.chromium.org/svn/trunk/third_party/opus/opus.h" target="_blank">http://src.chromium.org/svn/trunk/third_party/opus/opus.h</a> seems to be<br>
redundant. If USE_SYSTEM_OPUS isn't defined, opus.gyp only exports<br>
-Isrc/include to dependencies, and if it _is_ defined, it exports<br>
whatever pkg-config returns for the system include path. In neither case<br>
will this header be picked up; I suggest just removing the file.<br></blockquote><div><br></div><div>This is tricky. Google Chrome bundles several libraries including Opus. But Linux distros want to build with system Opus. To support both cases in a maintainable way, all Chromium code refers to (#includes) this shim header by it's full path "third_party/opus/opus.h".</div>
</div>