<br><font size=2 face="sans-serif">It is indeed a 16 bits char architecture
and this explains the problem since end_bits_left is 0. Anyway a correct
initialization should be preferable in this case.</font>
<br>
<br><font size=2 face="sans-serif">Unrelated question: i see that CELT
has been already ported to TI platform. I'd need some performance estimation
on those DSPs. I see that you wrote fixed_c5x.h header file, would you
mind giving me some number if you have them?</font>
<br>
<br><font size=2 face="sans-serif">Regards</font>
<br><font size=2 face="sans-serif">Riccardo<br>
</font>
<table>
<tr>
<td>
<hr noshade>
<p><font size=1 face="Arial">Riccardo Micci<br>
Senior DSP Engineer, Wireless Group </font>
<p><font size=1 color=#4181c0 face="Arial"><b>Cambridge Consultants</b></font><font size=1 face="Arial"><br>
Science Park, Milton Road <br>
Cambridge, CB4 0DW, England<br>
Switchboard: +44 (0)1223 420024<br>
Direct dial: +44 (0)1223 392402<br>
Mobile: +44 (0)<br>
Fax: +44 (0)1223 423373</font><font size=1 color=blue face="Arial"><br>
</font><a href=mailto:riccardo.micci@cambridgeconsultants.com><font size=1 color=#4181c0 face="Arial">riccardo.micci@cambridgeconsultants.com</font></a><font size=1 color=blue face="Arial"><br>
</font><a href=http://www.cambridgeconsultants.com/><font size=1 color=#4181c0 face="Arial">www.CambridgeConsultants.com</font></a><font size=1 face="Arial"><br>
</font></table>
<br>
<br>
<br>
<br>
<table width=100%>
<tr valign=top>
<td width=40%><font size=1 face="sans-serif"><b>Jean-Marc Valin <Jean-Marc.Valin@USherbrooke.ca></b>
</font>
<p><font size=1 face="sans-serif">02/09/2010 14:14</font>
<td width=59%>
<table width=100%>
<tr valign=top>
<td>
<div align=right><font size=1 face="sans-serif">To</font></div>
<td><font size=1 face="sans-serif">Riccardo Micci <riccardo.micci@cambridgeconsultants.com></font>
<tr valign=top>
<td>
<div align=right><font size=1 face="sans-serif">cc</font></div>
<td><font size=1 face="sans-serif">celt-dev@xiph.org</font>
<tr valign=top>
<td>
<div align=right><font size=1 face="sans-serif">Subject</font></div>
<td><font size=1 face="sans-serif">Re: [CELT-dev] Possible Bug</font></table>
<br>
<table>
<tr valign=top>
<td>
<td></table>
<br></table>
<br>
<br>
<br><tt><font size=2>Riccardo Micci <riccardo.micci@cambridgeconsultants.com>
a écrit :<br>
> (s=ec_decode_raw(_this,_ftb);).<br>
> In ec_decode_raw within the while loop the following line is executed:<br>
> value |= _this->end_byte>>(8-_this->end_bits_left)<<count;<br>
> As you can see end_byte is read and used before nothing else has written<br>
> in it before.<br>
> This produce different results on different platforms.<br>
<br>
When executing<br>
value |= _this->end_byte>>(8-_this->end_bits_left)<<count;<br>
the first time, the value of _this->end_bits_left should be equal to
<br>
0, which means that we are shifting _this->end_byte (an unsigned char)
<br>
by 8, so the result should be zero regardless of the content of <br>
_this->end_byte. Can you check whether _this->end_bits_left is really
<br>
zero when you see the problem happening? It could be either the <br>
symptoms of an unrelated issue or something wrong with your build <br>
setup. On what platform do you see the problem occurring (any chance <br>
it's one with 16-bit chars)?<br>
<br>
Cheers,<br>
<br>
Jean-Marc<br>
<br>
> Regards<br>
> Riccardo<br>
><br>
> Riccardo Micci<br>
> Senior DSP Engineer, Wireless Group<br>
> Cambridge Consultants<br>
> Science Park, Milton Road<br>
> Cambridge, CB4 0DW, England<br>
> Switchboard: +44 (0)1223 420024<br>
> Direct dial: +44 (0)1223 392402<br>
> Mobile: +44 (0)<br>
> Fax: +44 (0)1223 423373<br>
> riccardo.micci@cambridgeconsultants.com<br>
> www.CambridgeConsultants.com<br>
><br>
><br>
><br>
><br>
><br>
> Jean-Marc Valin <Jean-Marc.Valin@USherbrooke.ca><br>
> 02/09/2010 13:41<br>
><br>
> To<br>
> celt-dev@xiph.org<br>
> cc<br>
> riccardo.micci@cambridgeconsultants.com<br>
> Subject<br>
> Re: [CELT-dev] Possible Bug<br>
><br>
><br>
><br>
><br>
><br>
><br>
>> The problem comes decoding the next frame. Since now "shortBlocks"
is<br>
> false,<br>
>> "end_byte" is not initialized anymore and next functions
read it before<br>
>> update.<br>
>><br>
>> Can someone confirm this behaviour? In my case i modified ec_dec_init<br>
>> function to initialize it as well. What is the correct value?<br>
><br>
> Can you give a bit more information on what's happening? The end_byte<br>
> field does not need to be initialized because it should get read when<br>
> end_bits_left is zero. In what function is the uninitialized read<br>
> happening and what happens then?<br>
><br>
> Jean-Marc<br>
><br>
><br>
><br>
><br>
><br>
><br>
><br>
> This email is from Cambridge Consultants Limited, Science Park, Milton<br>
> Road, Cambridge CB4 0DW with registered number 1036298 England. It
may<br>
> contain confidential information. It is intended for the addressee
only<br>
> and may not be copied or disclosed to any third party without our<br>
> permission. If you are not the intended recipient please contact the<br>
> sender as soon as possible and delete the material from any computer.
If<br>
> this email has been sent as a personal message to the addressee, the<br>
> sender is not acting in his/her capacity as an employee or officer
of<br>
> Cambridge Consultants Limited and no liability is accepted for the
content<br>
> of any such email. Outgoing email may be monitored for the purpose
of<br>
> ensuring compliance with our email policy and relevant laws.<br>
><br>
><br>
><br>
<br>
<br>
<br>
</font></tt>
<br><font size=3 face="sans-serif"><br>
</font>
<br><font size=3 face="sans-serif"><br>
</font>
<hr><font size=1 face="Arial"><br>
<br>
This email is from Cambridge Consultants Limited, Science Park, Milton
Road, Cambridge CB4 0DW with registered number 1036298 England. It may
contain confidential information. It is intended for the addressee only
and may not be copied or disclosed to any third party without our permission.
If you are not the intended recipient please contact the sender as soon
as possible and delete the material from any computer. If this email has
been sent as a personal message to the addressee, the sender is not acting
in his/her capacity as an employee or officer of Cambridge Consultants
Limited and no liability is accepted for the content of any such email.
Outgoing email may be monitored for the purpose of ensuring compliance
with our email policy and relevant laws.</font><font size=3 face="sans-serif"><br>
</font>
<br>
<br>