<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:times new roman, new york, times, serif;font-size:12pt"><DIV>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">Jean-Marc,<?xml:namespace prefix = o ns = "urn:schemas-microsoft-com:office:office" /><o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">I wish I could take credit for finding the bug, but I'll have to give credit to my compiler....:)<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">Let's now take a look at this code in bands.c<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">"<SPAN style="mso-spacerun: yes"> </SPAN>quant_band(encode, m, i, X, Y, N, b, spread, tf_change, lowband, resynth, ec, &remaining_bits, LM, norm+M*eBands[i], bandE, 0);"<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">My compiler says:<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">"argument of type "int *" is incompatible with parameter of type "celt_int32 *"<SPAN style="mso-tab-count: 1"> </SPAN>libcelt80/libcelt<SPAN style="mso-tab-count: 1"> </SPAN>bands.c<SPAN style="mso-tab-count: 1"> </SPAN>line 951<SPAN style="mso-tab-count: 1"> </SPAN>1278452093812<SPAN style="mso-tab-count: 1"> </SPAN>9084"<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">I'm not exactly sure where the problem is. Can you see it?<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">MikeH<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">-----Original Message-----<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">From: Jean-Marc Valin [mailto:jean-marc.valin@usherbrooke.ca] <o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">Sent: Tuesday, July 06, 2010 6:00 PM<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">To: Mike Hooper Hooper<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">Cc: celt-dev@xiph.org<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">Subject: Re: [CELT-dev] V0.8.0 Problems<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">Hi Mike,<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">Indeed, you found a bug! I missed it because the symptoms you saw only <o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">occurs in fixed-point with compilers that don't have var arrays or <o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">alloca(). It's fixed in git now. For now (commit b6a5f9), the git master <o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">branch is bitstream compatible with 0.8.0. I'll probably issue a 0.8.1 <o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">bugfix release after we fix any remaining problems you have.<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">Cheers,<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New"><SPAN style="mso-tab-count: 1"> </SPAN>Jean-Marc<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><o:p><FONT size=2 face="Courier New"> </FONT></o:p></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">On 10-07-06 04:52 PM, Mike Hooper Hooper wrote:<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> Tim, et al,<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> I have run into several problems with V0.8.0. I will address them<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> seperately.<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> 1. My compiler is complaining about the following code in celt.c which<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> seems to define metric first as celt_word32, then as celt_word16. Am I<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> mis-interpreting something?<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> VARDECL(celt_word32, metric);<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> ALLOC(metric, len, celt_word16);<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> Thx<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> MikeH<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">><o:p> </o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">><o:p> </o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">><o:p> </o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> _______________________________________________<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> celt-dev mailing list<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> celt-dev@xiph.org<o:p></o:p></FONT></FONT></P>
<P style="MARGIN: 0pt" class=MsoPlainText><FONT size=2><FONT face="Courier New">> http://lists.xiph.org/mailman/listinfo/celt-dev<o:p></o:p></FONT></FONT></P></DIV></div></body></html>