[opus] Antw: Re: [PATCH] Support for Channel Mapping 253.

[Drew Allen]

Hi Ulrich,

Thank you for your input! Ptal at the patch I set above and let me know if
it's been resolved to your liking.

Cheers,
Drew

On Mon, Oct 16, 2017 at 3:54 AM Ulrich Windl <
Ulrich.Windl at rz.uni-regensburg.de> wrote:

> >>> Drew Allen <bitllama at google.com> schrieb am 10.10.2017 um 20:29 in
> Nachricht
> <CABQ9DctQ0+gBgUif7BBJpjjKR7_V_H5OC1JM47w50oaaLXL4Tg at mail.gmail.com>:
> > Hi Jean-Marc,
> >
> > Thanks for the feedback. Attached are my comments and an updated patch.
> >
> > 1) I see that it's adding an #include of stdarg.h to opus_multistream.h
> > Is that left over from the previous version?
> >
> >
> > *That was a typo. Fixed.*
> >
> > 2) Someone on this list might know better than I do on that one, but for
> > the new _ctl_va_list() calls, I believe the convention is for va_start()
> > and va_end() to appear in the caller rather than in in the va_list()
> > function itself.
> >
> > *My understanding is that it's impossible to pass ellipsis to another
> > function.*
>
> From "man stdarg.h": " The object ap may be passed as an argument to
> another function; (...)". See also "va_copy()".
>
> [...]
>
> Regards,
> Ulrich
>
>
>
> _______________________________________________
> opus mailing list
> opus at xiph.org
> http://lists.xiph.org/mailman/listinfo/opus
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/opus/attachments/20171023/3e46489e/attachment.html>