[opus] [PATCH] Don't use MAY_HAVE_NEON in arm_silk_map.c.

Jonathan Lennox jonathan at vidyo.com
Fri Jun 2 19:53:11 UTC 2017


It's unnecessary, and isn't defined correctly on floating-point.

This makes us correctly use Neon functions (in floating-point mode) on
platforms where Neon is detected by RTCD.
---
 silk/arm/arm_silk_map.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/silk/arm/arm_silk_map.c b/silk/arm/arm_silk_map.c
index 53a60a0..04767b5 100644
--- a/silk/arm/arm_silk_map.c
+++ b/silk/arm/arm_silk_map.c
@@ -48,7 +48,7 @@ void (*const SILK_BIQUAD_ALT_STRIDE2_IMPL[OPUS_ARCHMASK + 1])(
       silk_biquad_alt_stride2_c,              /* ARMv4 */
       silk_biquad_alt_stride2_c,              /* EDSP */
       silk_biquad_alt_stride2_c,              /* Media */
-      MAY_HAVE_NEON(silk_biquad_alt_stride2), /* Neon */
+      silk_biquad_alt_stride2_neon,			  /* Neon */
 };
 
 opus_int32 (*const SILK_LPC_INVERSE_PRED_GAIN_IMPL[OPUS_ARCHMASK + 1])( /* O   Returns inverse prediction gain in energy domain, Q30        */
@@ -58,7 +58,7 @@ opus_int32 (*const SILK_LPC_INVERSE_PRED_GAIN_IMPL[OPUS_ARCHMASK + 1])( /* O   R
       silk_LPC_inverse_pred_gain_c,              /* ARMv4 */
       silk_LPC_inverse_pred_gain_c,              /* EDSP */
       silk_LPC_inverse_pred_gain_c,              /* Media */
-      MAY_HAVE_NEON(silk_LPC_inverse_pred_gain), /* Neon */
+      silk_LPC_inverse_pred_gain_neon,			 /* Neon */
 };
 
 void  (*const SILK_NSQ_DEL_DEC_IMPL[OPUS_ARCHMASK + 1])(
@@ -81,7 +81,7 @@ void  (*const SILK_NSQ_DEL_DEC_IMPL[OPUS_ARCHMASK + 1])(
       silk_NSQ_del_dec_c,              /* ARMv4 */
       silk_NSQ_del_dec_c,              /* EDSP */
       silk_NSQ_del_dec_c,              /* Media */
-      MAY_HAVE_NEON(silk_NSQ_del_dec), /* Neon */
+      silk_NSQ_del_dec_neon,		   /* Neon */
 };
 
 /*There is no table for silk_noise_shape_quantizer_short_prediction because the
@@ -115,7 +115,7 @@ void (*const SILK_WARPED_AUTOCORRELATION_FIX_IMPL[OPUS_ARCHMASK + 1])(
       silk_warped_autocorrelation_FIX_c,              /* ARMv4 */
       silk_warped_autocorrelation_FIX_c,              /* EDSP */
       silk_warped_autocorrelation_FIX_c,              /* Media */
-      MAY_HAVE_NEON(silk_warped_autocorrelation_FIX), /* Neon */
+      silk_warped_autocorrelation_FIX_neon,			  /* Neon */
 };
 
 # endif
-- 
1.9.1



More information about the opus mailing list