[opus] Antw: Re: 2 patches related to silk_biquad_alt() optimization
Ulrich.Windl at rz.uni-regensburg.de
Tue Apr 25 06:30:54 UTC 2017
>>> Linfeng Zhang <linfengz at google.com> schrieb am 25.04.2017 um 01:52 in Nachricht
<CAKoqLCDvAk7eeS-gpmqSHVxp4t-Lzzw7TLo5rRo=Ey_Q==cxGg at mail.gmail.com>:
> Hi Ulrich,
> As Jean-mark recommended, we created "--enable-check-asm" config option to
> active OPUS_CHECK_ASM macros in the optimization, where the C function is
> called inside and the results of C and optimization functions are compared
> when encoding/decoding the real audio files.
My question was on the audio files: Considering that different code paths are used depending on the input material (and possibly also depending on the command line flags), is there a test suite that exercises all code paths, or do you use just a random example to check?
> On Wed, Apr 19, 2017 at 11:46 PM, Ulrich Windl <
> Ulrich.Windl at rz.uni-regensburg.de> wrote:
>> >>> Linfeng Zhang <linfengz at google.com> schrieb am 19.04.2017 um 18:29 in
>> <CAKoqLCDX3eCUGbnZFvRzhiCV1Mbo2ksbj8K+pcVu60Dvit7WCQ at mail.gmail.com>:
>> > Hi,
>> > Attached are 2 patches related to silk_biquad_alt() optimization. Please
>> > review.
>> Out of curiosity: How do you test "The optimization is bit exact with C
>> function."? Use one example, or use a few random examples, or use a defined
>> test suite? Or is is done per code inspection?
>> > Thanks,
>> > Linfeng Zhang
More information about the opus