[opus] [PATCH 9/9] Optimize silk_inner_prod_aligned_scale() for ARM NEON

Timothy B. Terriberry tterribe at xiph.org
Sun Sep 4 14:31:28 UTC 2016


Linfeng Zhang wrote:
> Created corresponding unit test, and the optimization is bit exact with C
> function.

How are you building/running these tests? None of the tests (from any of 
the patches starting with the second) build for me on 32-bit ARMv7 with 
--enable-fixed-point, or even on x86. Example errors:

   CCLD     tests/test_unit_optimization
tests/test_unit_optimization.o: In function `test_fir':
/home/derf/src/xiph/git/xiph/opus/build/../celt/tests/test_unit_optimization_lpc.c:58: 
undefined reference to `CELT_FIR_IMPL'
/home/derf/src/xiph/git/xiph/opus/build/../celt/tests/test_unit_optimization_lpc.c:65: 
undefined reference to `CELT_FIR_IMPL'
/home/derf/src/xiph/git/xiph/opus/build/../celt/tests/test_unit_optimization_lpc.c:77: 
undefined reference to `celt_fir_c'
tests/test_unit_optimization.o: In function `main':
/home/derf/src/xiph/git/xiph/opus/build/../tests/test_unit_optimization.c:51: 
undefined reference to `opus_select_arch'
collect2: error: ld returned 1 exit status



More information about the opus mailing list