[opus] [PATCH] Add Functions to Create Ambisonic Multistream Encoder

Jean-Marc Valin jmvalin at jmvalin.ca
Tue May 24 04:28:56 UTC 2016

On 05/23/2016 10:57 PM, Michael Graczyk wrote:
> Since they correspond to mapping family values, I figured it would be
> wise to make them match so that the correspondence would be clear. If
> you would rather that correspondence not be explicit I will remove the
> explicit assignments.

I'd rather have them be different, since they're not really the same
thing. The idea is that we may have more than one family map to the same
type (e.g. currently both families 0 and 255 map to TYPE_NONE).

One last thing I just noticed, please don't rely on
ENABLE_EXPERIMENTAL_AMBISONICS actually being defined to zero when your
patch is disabled. Some people don't use the autotools build (e.g. they
use the plain Makefile or Visual Studio, or custom scripts), so your
patch would break their build. Instead, please rely on #ifdef's.



More information about the opus mailing list