[opus] [PATCH] Add Functions to Create Ambisonic Multistream Encoder
jmvalin at jmvalin.ca
Tue May 24 01:31:11 UTC 2016
Any particular reason you assign explicit values to your MappingType
enum? If not, I'd rather not depend on the int values. Other than that,
I think your patch is good to go.
On 05/23/2016 01:27 PM, Michael Graczyk wrote:
> Hi Jean-Marc,
> On Sat, May 21, 2016 at 1:58 PM, Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:
>> 1) I think "allocation mode" should be renamed to "mapping type" or
>> something similar that to make it less confusing.
>> 2) After discussing with Tim, the conclusion is that we should use
>> mapping family 254 in the short term. We can switch to mapping family 2
>> when standardization is a bit more advanced.
> Sounds good, done.
>> 3) Unless it causes problems in the existing code, it seems like family
>> 254 should already set mapping_type=MAPPING_TYPE_AMBISONICS. From my
>> understanding, it would not change the code behaviour, but would make it
>> clearer what the new type is for (or did I miss something?).
> Done, I think. The patch still doesn't change behavior, but it now
> sets the member OpusMSEncoder.mapping_type to MAPPING_TYPE_AMBISONICS.
More information about the opus