[opus] opus-tools: Fix potential uninitialized access for set-ctl-int

Michael Graczyk mgraczyk at google.com
Tue Apr 26 03:55:45 UTC 2016


Since the attachment was not treated as text, here is the patch inline:

---
 src/opusenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/opusenc.c b/src/opusenc.c
index 0f83194..cc84ed1 100644
--- a/src/opusenc.c
+++ b/src/opusenc.c
@@ -776,7 +776,7 @@ int main(int argc, char **argv)
       }
     }else if(target<header.nb_streams){
       OpusEncoder *oe;
-      opus_multistream_encoder_ctl(st,OPUS_MULTISTREAM_GET_ENCODER_STATE(i,&oe));
+      opus_multistream_encoder_ctl(st,OPUS_MULTISTREAM_GET_ENCODER_STATE(target,&oe));
       ret=opus_encoder_ctl(oe, opt_ctls_ctlval[i*3+1],opt_ctls_ctlval[i*3+2]);
       if(ret!=OPUS_OK){
         fprintf(stderr,"Error opus_encoder_ctl(st[%d],%d,%d)
returned: %s\n",target,opt_ctls_ctlval[i*3+1],opt_ctls_ctlval[i*3+2],opus_strerror(ret));
-- 

How do you guys prefer to receive patches? I'm fearful that Gmail will
mangle them if I send them inline line this.

On Mon, Apr 25, 2016 at 8:52 PM, Michael Graczyk <mgraczyk at google.com> wrote:
> Here is a simple patch to fix a bug in opusenc's set-ctl-int code
>
> --
>
> Thanks,
> Michael Graczyk



-- 

Thanks,
Michael Graczyk


More information about the opus mailing list