[opus] [RFC V3 7/8] armv7, armv8: Optimize fixed point fft using NE10 library
Phil.Wang at arm.com
Thu Oct 15 21:45:16 PDT 2015
Sorry for late reply. I have upstreamed the patch to fix the regression here:
I have tested it with Vish's branch:
Both unit test dft and unit test mdct passed on ARM v7/v8, floating point/fixed point, with or without Ne10.
From: Viswanath Puttagunta [mailto:viswanath.puttagunta at linaro.org]
Sent: Tuesday, October 06, 2015 11:40 PM
To: Timothy B. Terriberry
Cc: Phil Wang; opus at xiph.org; Viswanath Puttagunta; Tom Gall
Subject: Re: [opus] [RFC V3 7/8] armv7, armv8: Optimize fixed point fft using NE10 library
Great to hear from you!
Fired up my hardware today and this issue looks like a regression in
The commit in Ne10  that I tested to be working successfully back in May
which is the Patch Phil at ARM added to fix the overflow issue in nfft=60 case.
After git-bisect, looks like the culprit patch in Ne10  is
Please fix the regression at the earliest and let me know if you need any help.
On 5 October 2015 at 20:21, Timothy B. Terriberry <tterriberry at mozilla.com> wrote:
> I'm trying to get these cleaned up and landed, but I'm running into some trouble with this patch. Using commit a08b29d88e3c (July 21) of Ne10, I'm seeing test failures for 60-point FFTs:
> nfft=60 inverse=0,snr = -3.312408
> ** poor snr: -3.312408 **
> nfft=60 inverse=1,snr = -16.079597
> ** poor snr: -16.079597 **
> All other sizes tested appear to work fine (84 to 140 dB of SNR). This doesn't match the results you reported on this list in May, where the FFTs appeared to pass tests, but the MDCTs did not (the latter of which I presume was fixed by the May 12 commits to Ne10). I don't see any commits since then that I would expect to have broken this. Any ideas?
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782
More information about the opus