[opus] [RFC PATCH v1 2/2] armv7(float): Optimize encode usecase using NE10 library
viswanath.puttagunta at linaro.org
Fri Jan 30 15:41:22 PST 2015
On 30 January 2015 at 02:38, Timothy B. Terriberry <tterribe at xiph.org> wrote:
> Viswanath Puttagunta wrote:
>> Is the peak stack usage a complete blocker in current form?
> Since this only affects people who enable NE10, I don't think this is a blocker.
I discussed this and comment about _t with Phil at NE10_ARM. He committed
to two changes:
1. Change API to address usage of _t from NE10 api for following types:
ne10_int32_t ------> will become ----> ne10_int32
ne10_fft_cpx_float32_t ------> will become ----> ne10_fft_cpx_float32
ne10_fft_state_float32_t ------> will become ---> ne10_fft_state_float32
ne10_fft_cfg_float32_t -----> will become ----> ne10_fft_cfg_float32
2. Provide scaling as argument to ne10_fft_c2c_1d_float32_neon() and
remove need for one buffer on stack (ALLOC(tempin, st->nfft,
ne10_fft_cpx_float32_t);). We will still need cfg->buffer. So, peak
stack usage goes up by ~3.8K instead of ~7.5K.
Hope to get the RFCv2 by end of next week.
More information about the opus