[opus] [libopusfile PATCH] build: implement autotools build system for libopusfile.

Timothy B. Terriberry tterribe at xiph.org
Tue Sep 25 08:33:22 PDT 2012

Diego Elio Pettenò wrote:
> I've locally added the autogen.sh to call `autoreconf -fis` — will be in
> patch v2 by the end of the day.


> Fixed the assertions _but_ $(filter-out) requires you to actually give
> it a set of values to filter, so something along the lines of
> $(filter-out -O1 -O2 -O3 -Os,$(CFLAGS)) — but this is not really
> reliable, as gcc actually accepts -O4 -O5 -O6 etc. as aliases to -O3.

Does't "$(filter-out -O%,$(CFLAGS))" work? Speaking as someone who has 
cobbled together scripts to use for CC so they could translate gcc 
options into crazy embedded compiler options, I'd rather not rely on 
argument-parsing order.

> Done. Note that -Wall has to come before -Wno-* otherwise it'll always
> enable them.

Quite right (and of course what the existing Makefile actually does).

> Both are nice things to do, honestly. The Windows export list is easy to
> use with libtool, but using hidden visibility gets you some improvements
> during the compile step sometimes (not often, but sometimes).

I certainly have no issue with doing both.

Thanks for fixing these things so quickly. I look forward to seeing the 
updated patch.

More information about the opus mailing list