[CELT-dev] Celt 0.7.1 Fixed math

[Riccardo Micci]

Hi Jean-Marc,
Thanks! I actually realised it literally few seconds after sending the 
email. I just searched for another instance to see if it was used and i 
didn't realised it was the only one.


Cheers
Riccardo 


Riccardo Micci
Senior DSP Engineer, Wireless Group 
Cambridge Consultants
Science Park, Milton Road 
Cambridge, CB4 0DW, England
Switchboard: +44 (0)1223 420024
Direct dial: +44 (0)1223 392402
Mobile: +44 (0)
Fax: +44 (0)1223 423373
riccardo.micci at cambridgeconsultants.com
www.CambridgeConsultants.com
 




Jean-Marc Valin <Jean-Marc.Valin at USherbrooke.ca> 
08/09/2010 17:41

To
Riccardo Micci <riccardo.micci at cambridgeconsultants.com>
cc
celt-dev at xiph.org
Subject
Re: [CELT-dev] Celt 0.7.1 Fixed math






Riccardo Micci <riccardo.micci at cambridgeconsultants.com> a écrit :
> I'm using Celt 0.7.1 in fixed math mode. In the celt_encode function, if
> the variable has_pitch is true, the function pitch_search is called.
> Within this function the find_best_pitch subfunction is called.
> Here the variable "float score;" is defined.
> Is this right? I was expecting not to see any float declaration in the
> fixed math code. Is it possible to redefine it as integer?

Even better, you can remove it entirely since it's never actually 
used. That's the reason it took me a while to notice (it was fixed in 
git a few weeks ago) because the compiler would completely optimize it 
away. BTW, not sure what compiler you're using, but it doesn't seem to 
be very good at optimizing if it didn't remove that.

Cheers,

    Jean-Marc







This email is from Cambridge Consultants Limited, Science Park, Milton 
Road, Cambridge CB4 0DW with registered number 1036298 England. It may 
contain confidential information. It is intended for the addressee only 
and may not be copied or disclosed to any third party without our 
permission. If you are not the intended recipient please contact the 
sender as soon as possible and delete the material from any computer. If 
this email has been sent as a personal message to the addressee, the 
sender is not acting in his/her capacity as an employee or officer of 
Cambridge Consultants Limited and no liability is accepted for the content 
of any such email. Outgoing email may be monitored for the purpose of 
ensuring compliance with our email policy and relevant laws.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/opus/attachments/20100908/465675c5/attachment-0002.htm