[CELT-dev] git online viewer?

[Pascal Pochol]

On 11:29:27 am 10/14/10 Gregory Maxwell <gmaxwell at gmail.com> wrote:
> http://git.xiph.org/?p=celt.git;a=summary
> 
> Please share the warnings, however.

Thanks for the link. I was able to download the latest libcelt/celt.c and
one of the function which is causing a warning in CELT 0.8.1 no longer seem
to exist.

I must say that we use a custom made Makefile, not the one provided with
celt. I just got rid of one of the warnings after looking at the sources
and adding -DHAVE_LRINTF to my C99FLAGS since it seems to exist both under
Linux and MacOSX (the two platforms for which we use the Makefile).

Compiling ../Celt/libcelt/celt.c
./Celt/libcelt/celt.c:448: warning: ‘flag_bits’ may be used
uninitialized in this function
./Celt/libcelt/celt.c:448: note: ‘flag_bits’ was declared here

This was in the encode_flags function which no longer exist, so I assume
that when the next tarball comes around it'll get rid of that for me as
well.

We spend a bit effort to make sure that our code cross compile without any
warnings. In the long run it makes spotting real warnings that could cause
issues much easier.

I must say that we are really impressed with the compression ratio and
quality of celt at this point. Can't wait for the next tarball some of the
latest commit comments look interesting.

Thanks for the quick reply.

-Pascal