[CELT-dev] (no subject)

Timothy B. Terriberry tterribe at xiph.org
Thu Jul 1 13:14:01 PDT 2010


Mike Hooper wrote:
> Jean-Mark, Tim,
> 
>  
> 
> Could either of you expound on the following comment in cwrs.c?

That comment just meant the buffer must have at _least_ three elements, 
because the do loop writes to _u[2] before it checks the loop condition. 
ncwrs_row() is called from exactly two places, and both of them a) 
ensure that _k > 0 and b) allocate an array of size _k+2 right before 
passing it to ncwrs_row(). So if it's overflowing the buffer, that means 
the allocation failed. See gmaxwell's questions for things to start 
looking at to figure out why.



More information about the celt-dev mailing list