[ogg-dev] oggpack_writecopy bug

[Monty Montgomery]

Actually, I'm certain r17270 is the culprit.  I misapplied an overflow
check correction pattern in line 202.

I have a question about 'it thrashes the stack with very long
strings'; is this an observed behavior, or are you looking at the
code?  I see that unaligned copies are being allocated inefficiently
(I'll fix that too), but I'm not certain that matches your complaint.

Monty



On Wed, Apr 23, 2014 at 12:03 PM, Ian Nartowicz <ian at nartowicz.co.uk> wrote:
> At some stage (possibly commit r17268) oggpack_writecopy started to fail with
> some strings longer than 256 bytes and all strings longer than 512 bytes.  Also
> it thrashes the stack with very long strings.
>
> Lithopsian
> _______________________________________________
> ogg-dev mailing list
> ogg-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/ogg-dev