[ogg-dev] Fwd: Merging jorbis upstream and the cortado jorbis fork back into one

[Gregory Maxwell]

On Thu, Nov 4, 2010 at 11:46 AM, Hans de Goede <hdegoede at redhat.com> wrote:
> Note that I'm not packaging it (advertising the package) as an applet
> for in browser use / for serving over http, but rather packaging
> it as a java media playback framework, because it is used as such by
> several java games which we package. As such it only gets used
> with (and has been tested with) the jre which we ship.
>
> Also I've done a full diff between the jorbis upstream sources and
> the ones shipped with cortado and they are as good as entirely the
> same except for a few bugfixes in jorbis upstream which are not
> in cortado and visa versa. Atleast cortado should rebase (replace)
> its copy with the latest upstream jorbis release + the patch
> I attached to my original mail. This will fix a resource leak
> in VorbisFile, as well as 2 bugs in the tag handling code.

Hi Hans, the fact that you're packaging it for games not applet use
addresses my concern. Thank you, and thanks for your efforts here.  I
believe debian actually packages it as an applet.

You should be aware that cortado targets a wider set of JVMs than
Jorbis. In particular Cortado will run on the old MS JVMs that jorbis
will not (unless this has changed and it wasn't mentioned in the
jorbis changelog).  Syncing up with jorbis fixes sounds like a great
idea, but it's going to at least require some basic testing in old
JVMs, which is always a bit of a pain.

Someone also ought to perform a sweep of the recent libvorbis changes—
the Jorbis stuff was a rather literal port of the C code and probably
has some of these bugs in common.