[ogg-dev] Make check failure

Gregory Maxwell gmaxwell at gmail.com
Sun Apr 4 19:03:16 PDT 2010

Erik de Castro Lopo wrote:
>> I've just grabbed a copy of SVN head for libogg and 'make check'
>> is failing:
>The breakage happened in this commit:
>    r17098 | gmaxwell | 2010-03-29 16:35:11 +1100 (Mon, 29 Mar 2010) | 1 line
> Firstly, is gmaxwell on this list?
> Secondly should be be trying controvertial changes in HEAD? Surely thats
> what separate branches are for, so that the trunk never breaks like this.

Nothing is broken.  The libogg test-cases are especially particular
checks on exact (non-normative) aspects of the library behaviour. This
is fine for their intended use: catching compiler/porting bugs on
target systems, but it makes them less useful for development
regression testing.

In this case, I didn't update the test case while making the change.

Xiphmont left the tree in exactly the same state after making the
change to pack 4 frames, this was fixed in r17039.  As far as where
changes are made— we have _releases_ for the purpose of providing
stable code, though because the norm around here is to have a mostly
working trunk I never would have committed a change which could
reasonably have been expect to cause any real breakage.

As far as controversial goes, I probably should have put it in scare
quotes. The kind of controversial I'm talking about is the name of the
function I added (I don't like _fill() much myself, but nothing better
seemed obvious)  or the decision to add a somewhat kludgey additional
input function rather than break the ABI and add a one shot control.

If the new function stays it will likely need a test case. I'm not
going to write one until the decision is final that we'll go that


More information about the ogg-dev mailing list