[ogg-dev] Fixing ogg vorbis corruption caused by bad metadata

Adam Rosi-Kessel adam at rosi-kessel.org
Tue Jul 21 06:28:50 PDT 2009


Martin Leese wrote, on 7/15/2009 3:29 PM:
> Adam Rosi-Kessel<adam at rosi-kessel.org>  wrote:
>
>> So I've written a script to do the following:
> ...
>
> I have got lost.  Did you manage to identify the
> rogue software that corrupted the files in the
> first place?  In the greater scheme of things,
> fixing this (prevention) is more important than
> repairing the files (cure).

I finally got something like an explanation from the Mediamonkey 
developers. Here is their explanation as to why MM corrupted my files:

 > the problem was caused by the fact that Vorbis library uses alloca()
 > function on several places, which allocates memory on stack. We
 > changed it to alloc() and free() functions pair instead, which fixes
 > the problem. I suppose that it can easily happen to any other
 > application using Vorbis library, but the real problem depends on
 > stack settings of the particular application. In any case, I think it
 > might make sense for Vorbis developers to make this change.

I'm not sure exactly what to make of this, but it sounds perhaps like a 
stack overflow issue?

Adam


More information about the ogg-dev mailing list