[ogg-dev] [PATCH] ogginfo: various

Ivo Emanuel Gonçalves justivo at gmail.com
Wed Sep 24 14:36:34 PDT 2008

On 9/22/08, ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at googlemail.com> wrote:
> It fixes 32/64 bit %lld format bugs (vorbis and kate), adds a missing
> argument to a warning message, adds comments to what the return values of
> pageseek mean

So far so good.

> and doesn't read more data if unneeded (this will lessen the memory
> used, but might mean worse performance, so the previous code might have done
> this on purpose ?)

If you meant the "hole" thing, ogginfo seems to be badly coded here
because it will just start spamming non-stop that message while
reading anything not Ogg, which is quite unlikely to have been the
intent, so if it the patch forces it to stop before reaching the end
of the file that's probably for the best.  Will take a closer look
into this in the weekend.

Thank you.


More information about the ogg-dev mailing list