[ogg-dev] [PATCH] liboggplay - 64 bit fixes

Erik de Castro Lopo mle+la at mega-nerd.com
Tue May 20 04:39:25 PDT 2008


ogg.k.ogg.k at googlemail.com wrote:

> > I believe that the right (ie ISO C standard recommended) way of doing
> > this is:
> >
> >               printf("[%d] [duration %" PRId64 "] %s\n",
> 
> C99 only,

Well, we are a little over 6 months away from 2009, so maybe,
just maybe it might be time to start coding to the ten year
old standard :-).

Besides, this is something that is very easy to implement for
systems which aren't C99.

> and ugly as hell

IMO, its less ugly than the cast, but only just.

> I can post an updated patch using this instead if preferred ?

Not up to me, but I vote in favour of using C99 features where
they can be and where its alos pretty easy to implement them for
systems which aren't C99.

Cheers,
Erik
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"Every day, as society progresses and the benefits of science and
education spread, another tooth is yanked from jaw of religion. Just
as Christianity went from wolf to lapdog in the Western world, so will
go Islam." -- http://reddit.com/r/politics/info/6dv47/comments/c03krei


More information about the ogg-dev mailing list