[ogg-dev] validator.annodex.org

[Conrad Parker]

On Thu, Feb 16, 2006 at 09:15:29PM +0000, Ian Malone wrote:
> 
> I think it's simpler than that:
> /src/tools/oggz-validate.c
> Line 176, the return value of ot_page_identify is not checked before
> being handed to strcmp.
> 
> Inserting a check for a valid pointer seems to fix it, the multi-xml
> packet streams then give a string of:
> 00:00:00.002: serialno 1044457395: Packet out of order (previous 
> 00:00:00.944)
> errors, which is as it should be since the granulepos of the xml
> packets is nonsensical. (Monotonically increasing, but nonsensical,
> the aim of those streams is testing that applications can ignore them
> for seeking.)

Hi Ian,

sorry, I missed the word "segfault" in your previous email :) In my
defence, I'd only just woken up and not had coffee yet.

I've committed the fix you suggested (changeset:2065) and also audited
the same problem in the other tools (changeset:2066), though there it
only happens if you were filtering on content type (eg. you try
to do "oggzdump -c vorbis" on one of those streams, to dump only the
vorbis).

It's 9am and there's an empty coffee cup next to me, which I don't at
all recall drinking.

cheers,

Conrad.