[libannodex-dev] [BUG] [PATCH] `oggzdump -r' broken

[Conrad Parker]

On Thu, Jan 06, 2005 at 01:57:26PM +0100, David Kuehling wrote:
> > excellent, that's the right thing to do :) I've applied the patch to
> > svn.
> 
> It was somehow counter-intuitive as writing has to be done directly,
> circumventing the liboggz-write API...  maybe high-level abstraction
> just doesn't fit with something as bare-bone as the ogg-container :)

yes :) if you've already got ogg pages anyway ...

> > I'll want to add a man page before releasing it, do you reckon you
> > could write one up? it should be pretty trivial to base it on the sgml
> > sources for oggzmerge(1) and anxrip(1).
> 
> When do you plan to release a new version?  If some time still remains,
> I'd prefer to add the missing features (ripping between start- and
> end-offsets) before adding a man-page.

when? as soon as the current round of feature additions is consistent --
ie. if there was an oggzrip man page, I'd be happy to release already :)

> I thought that liboggz was specifically designed to hide this kind of
> codec-specific knowledge.  After all, it uses its own codec-detection
> code when opening ogg-streams with OGGZ_AUTO.  And it can already
> interpret theora granulepos-values.  What does codec-independant seeking
> help, if I cannot find the next keyframe?

ok, good point :) ...

> >> Also I'd like to have access to codec-names for streams opened via
> >> OGGZ_AUTO, `oggzrip' currently uses its own code for detecting the
> >> codec.
> 
> > awesome, that's where that kind of identification belongs.
> 
> I don't understand, you mean that duplicating the auto-detection code is
> really a good idea?

sorry, I meant it belongs in the library, not in each tool! :)

> > In general, I'd prefer if the "codec-name" parts were reworded to
> > "content-type", and to allow content-type matches like "audio/*" in
> > the tools (in oggzdump as well :)
> 
> Well, that shouldn't be a problem.  Is `fnmatch' supported with the
> windows-compiler toolchain you use? :)

I'd doubt it, Windows has pretty poor support for any standards at all
:)

cheers,

kfish.