[libannodex-dev] [BUG] [PATCH] `oggzdump -r' broken

[David Kuehling]

Hi,

just downloaded the oggz tools for postprocessing some theora/vorbis
files.  I ended up using the following command for removing the audio
track from a Theora file:

oggzdump -x -s 0185147174 theora.ogg | oggzdump -r -o vid.theora.ogg  -

Strangely, the resulting file `vid.theora.ogg' was bigger than the
original `theora.ogg', which seems to be due to a bug in `oggzdump.c'.
`ogginfo' also reports the file to be broken.  A single-line patch
(against SVN) that fixes the problem for me is attached.

BTW that pipeline only runs at 1Mb/s on my 1.6GHz Athlon, with 100%
cpu-load.  Would be neat to have some stream filtering ability in the
liboggz tools.  Anybody mind if I implemented a simple `oggzextract'
utility?

regards,

David
-- 
GnuPG public key: http://user.cs.tu-berlin.de/~dvdkhlng/dk.gpg
Fingerprint: B17A DC95 D293 657B 4205  D016 7DEF 5323 C174 7D40

-------------- next part --------------
Index: src/tools/oggzdump.c
===================================================================
--- src/tools/oggzdump.c	(revision 656)
+++ src/tools/oggzdump.c	(working copy)
@@ -290,7 +290,7 @@
 	}
 
 	while ((n = oggz_write_output (oggz, buf, 1024)) > 0) {
-	  fwrite (buf, 1, 1024, outfile);
+	  fwrite (buf, 1, n, outfile);
 	}
       }