[Icecast] YP listings in version 2.5 beta

[Petr Pisar]

On Sun, Feb 03, 2019 at 08:06:49PM +1000, Damian wrote:
> This thread seems to have stalled. Would anyone still be able to help me
> with this one? I’ve posted my log as requested.
> 
> Any advice would be a great help.
>
You have all the data needed to resolve the issue.

> > I installed from source using the tarball icecast-2.5-beta2.tar.gz
> > <http://downloads.xiph.org/releases/icecast/icecast-2.5-beta2.tar.gz> on
> > the icecast homepage. I installed my current working version 2.4.4 in the
> > same way and installed curl at that time. The log is added below as
> > requested.

$ tar xzf icecast-2.5-beta2.tar.gz
$ cd icecast-2.4.99.2

> >> [2019-01-28  21:17:18] INFO main/main Icecast 2.4.99.2 server started
> >> [2019-01-28  21:17:18] INFO main/__log_system_name Running on systrum.net <http://systrum.net/>; OS: Linux 4.9.0-8-amd64, systrum.net <http://systrum.net/>, #1 SMP Debian 4.9.130-2 (2018-10-27), x86_64; Address Bits: 64
> >> [2019-01-28  21:17:18] WARN main/main YP server handling has been disabled

$ grep -C 20 -Hnr 'YP server handling has been disabled'
src/yp.h-24-#define  YP_CURRENT_SONG        8
src/yp.h-25-#define  YP_CLUSTER_PASSWORD    9
src/yp.h-26-#define  YP_SUBTYPE             10 
src/yp.h-27-
src/yp.h-28-#define YP_ADD_ALL              -1
src/yp.h-29-
src/yp.h-30-#ifdef USE_YP
src/yp.h-31-void yp_add (const char *mount);
src/yp.h-32-void yp_remove (const char *mount);
src/yp.h-33-void yp_touch (const char *mount);
src/yp.h-34-void yp_recheck_config (ice_config_t *config);
src/yp.h-35-void yp_initialize(void);
src/yp.h-36-void yp_shutdown(void);
src/yp.h-37-
src/yp.h-38-#else
src/yp.h-39-
src/yp.h-40-#define yp_add(x)               do{}while(0)
src/yp.h-41-#define yp_remove(x)            do{}while(0)
src/yp.h-42-#define yp_touch(x)             do{}while(0)
src/yp.h-43-#define yp_recheck_config(x)    do{}while(0)
src/yp.h:44:#define yp_initialize()         ICECAST_LOG_WARN("YP server handling has been disabled")
src/yp.h-45-#define yp_shutdown()           do{}while(0)
src/yp.h-46-
src/yp.h-47-#endif /* USE_YP */
src/yp.h-48-
src/yp.h-49-#endif
src/yp.h-50-
src/yp.h-51-

So your build does not define USE_YP. Why?

$ grep -Hnr USE_YP
configure:14723:$as_echo "#define USE_YP 1" >>confdefs.h
configure.ac:133:    AC_DEFINE([USE_YP], 1, [Define to compile in YP support code])
src/cfgfile.c:577:#ifdef USE_YP
src/cfgfile.c:653:#ifdef USE_YP
src/yp.h:30:#ifdef USE_YP
src/yp.h:47:#endif /* USE_YP */
config.h.in:197:#undef USE_YP

Why did not configure.ac do that:

   113  XIPH_PATH_CURL([
   114      AC_CHECK_DECL([CURLOPT_NOSIGNAL],
   115          [ AC_DEFINE([HAVE_AUTH_URL], 1, [Define to compile in auth URL support code])
   116          AC_CHECK_FUNCS([curl_global_init])
   117          ICECAST_OPTIONAL="$ICECAST_OPTIONAL auth_url.o event_url.o curl.o"
   118          enable_curl="yes"
   119          XIPH_VAR_APPEND([XIPH_CPPFLAGS],[$CURL_CFLAGS])
   120          XIPH_VAR_PREPEND([XIPH_LIBS],[$CURL_LIBS])
   121          ], [ AC_MSG_NOTICE([Your curl dev files are too old (7.10 or above required)])
   122          ], [#include <curl/curl.h>
   123          ])
   124      ],[ AC_MSG_NOTICE([libcurl not found])
   125      ])
   126  dnl -- YP support --
   127  AC_ARG_ENABLE([yp],
   128          AC_HELP_STRING([--disable-yp],[disable YP directory support]),
   129          enable_yp="$enableval",
   130          enable_yp="yes")
   131  if test "x$enable_yp" = "xyes" -a "x$enable_curl" = xyes
   132  then
   133      AC_DEFINE([USE_YP], 1, [Define to compile in YP support code])
   134      ICECAST_OPTIONAL="$ICECAST_OPTIONAL yp.o"
   135  else
   136      AC_MSG_NOTICE([YP support disabled])
   137  fi

Either you called ./configure with --disable-yp or with --without-curl (see
XIPH_PATH_CURL definitio in m4/xiph_curl.m4) or your
curl does meet the tested criteria. E.g. You are missing curl header files or
you have too old curl. What does ./configure output tell about curl support?

-- Petr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.xiph.org/pipermail/icecast/attachments/20190203/fbf616ef/attachment.sig>