[Icecast] Check feed connected, active - IceCast 2.4.x

[Philipp Schafft]

reflum,

On Sun, 2015-04-12 at 22:55 -0300, Alejandro wrote:
> Here can take a look other
> alternative: https://github.com/cdgraff/icecast-mon

Thank you for sharing!


> We base our solution in avprobe/ffprobe, this test like a real
> listener.
> 
> 
> Feedback is welcome! this is just first release, but we use on
> production.

Have a little bit of feedback. :)

in icecast_mon.py:80 you construct a string with an URL embedded.
in icecast_mon.py:83 you split it again.

I think you would be better off by constructing an array directly. The
current implementation may be prone to errors based on meta characters
in the URL. (This isn't super unlikely. Already had a similar case on a
Icecast setup myself where mount points contained such special
characters.)

Thank you for your work!

-- 
Philipp.
 (Rah of PH2)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://lists.xiph.org/pipermail/icecast/attachments/20150413/445a7ea3/attachment.sig>