[Icecast] Icecast dies

[oddsock]

latest kh build is here : 
http://www.oddsock.org/icecast/icecast2_win32_kh_trunk_07292005_setup.exe

oddsock
At 04:56 AM 7/29/2005, Ricardo Meechan wrote:
>Genuis karl! The change sorted it.
>Now when the source disconnects, the winamp stream just stopped (and
>went onto the next stream in the playlist in my case)
>
>Cheers for your help,
>
>
>Oddsock,
>could you build a compiled windows version of icecast with this fix (and
>also the relay on demand default setting as enabled, also fixed by karl)
>Whenever you have a spare moment, it would make me very very happy! Im
>still trying to build my own in VS.net 2003 but getting nowhere ;-)
>
>
>Cheers guys!
>
>
>-----Original Message-----
>From: Karl Heyes [mailto:karl at xiph.org]
>Sent: 29 July 2005 2:02 AM
>To: Ricardo Meechan
>Subject: RE: [Icecast] Icecast dies
>
>On Fri, 2005-07-29 at 00:58, Ricardo Meechan wrote:
> > Hola,
> >
> > Heres the backtrace (I think)
> >
> > (gdb) bt
> > #0  0x08055d8c in source_move_clients (source=0x9b9ffb0,
> > dest=0x9ba00f0) at source.c:359
> > #1  0x08054378 in start_relay_stream (arg=0x9b9fdd8) at slave.c:341
> > #2  0x0806a9d0 in _start_routine (arg=0x9ba8768) at thread.c:578
> > #3  0x00835b80 in start_thread () from /lib/libpthread.so.0
> > #4  0x0078ddee in clone () from /lib/libc.so.6
> > (gdb)
>
>yeah, that's the stuff we want.
>
>interesting, the actual segv reason is easy enough to resolve, I'm just
>wondering what the state of the listener is in at the time. It will be
>hard to tell from the core, as some changes to the client have been made
>by the time the core occurs.
>
>anyway, try the following
>
>in source.c line 359 change
>
>                 if (source->client->con == NULL)
>                     client->intro_offset = -1; to
>                 if (source->client && source->client->con == NULL)
>                     client->intro_offset = -1;
>
>make debug install
>
>re-run test, let me know just in case it's not the only problem your
>seeing.
>
>karl.
>
>
>
>Ricardo Meechan
>IT Administrator
>Mobile: +44 (0) 7966 484 371
>
>Wilson & Garden LTD
>t: +44 (0) 1236 823291
>f: +44 (0) 1236 825683
>
>
>Company registered in Scotland  SC267457
>
>NOTE: All emails to and from Wilson & Garden are protected by Antivirus 
>and spam filters.
>We use Trend Scanmail for AV and spamhaus.org & spamcop.net for spam 
>filtering.
>
>This message (and any associated files) is intended only for the use of 
>the individual or entity to which it is addressed and may contain 
>information that is confidential, subject to copyright or constitutes a 
>trade secret. If you are not the intended recipient you are hereby 
>notified that any dissemination, copying or distribution of this message, 
>or files associated with this message, is strictly prohibited. If you have 
>received this message in error, please notify us immediately by replying 
>to the message and deleting it from your computer. Messages sent to and 
>from us may be monitored.
>
>Internet communications cannot be guaranteed to be secure or error-free as 
>information could be intercepted, corrupted, lost, destroyed, arrive late 
>or incomplete, or contain viruses. Therefore, we do not accept 
>responsibility for any errors or omissions that are present in this 
>message, or any attachment, that have arisen as a result of e-mail 
>transmission. If verification is required, please request a hard-copy 
>version. Any views or opinions presented are solely those of the author 
>and do not necessarily represent those of the company.
>
>
>
>
>