<div dir="ltr">On Tue, Jun 25, 2013 at 2:36 PM, "Thomas B. Rücker" <span dir="ltr"><<a href="mailto:thomas@ruecker.fi" target="_blank">thomas@ruecker.fi</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Generic patches supplied by the community that target the 'pass through'<br>
legacy functionality of Icecast will be merged pending usual review. In<br>
the causa at hand, think 'allow a mime-type to be passed to libshout'<br>
this would also address codec extensions: 'audio/ogg; codecs=opus' and<br>
be generally useful.<br>
<br></blockquote><div><br></div><div style>This sounds quite reasonable. But the way libshout is designed entangles it with the formats it supports. It's not possible to set a custom mimetype. It's not possible to provide a custom shout_open_XXX function for a stream -- instead you have to call shout_set_format with a SHOUT_FORMAT_XXX which has a fixed list of shout_open_XXX functions that it calls. </div>
<div style><br></div><div style>Would you support patches that make this generic to allow formats that libshout does not explicitly support? That way all the AAC code (open/send/close stream) that e.g. <a href="https://trac.xiph.org/attachment/ticket/1872/libshout-2.3.0-aac-mime-aim-irc-icq.v2.patch">this</a> patch adds could live outside of libshout. For example, what if we added a SHOUT_FORMAT_CUSTOM format for which you provide a custom shout_open_XXX function and a custom mime type?</div>
<div style><br></div><div style>Warm regards,</div><div style>RJ Ryan</div><div><br></div></div></div></div>