For our source clients, I use mpd, ices, ezstream, vlc media player, and oddcast. They all have very unique advantages and disadvantages, which is why we use so many. It would be great to build one *super* icecast source client that could do what all of those other ones do (but not really feasible I suppose). Among these clients, Oddcast doesn't send out album metadata, but it is the one we use for streaming a live input. For streaming ogg vorbis, oddcast inserts the metadata directly into the vorbis header. But another way to set metadata would be to send an admin command to icecast to update the metadata (i believe this is what libshout does). However, icecast allows you to only set the Trackname or the Artist and Trackname. If needed, it would be very easy to update icecast to accept an album value as well. I believe then you could use libshout with no modifications to update the album metadata.
<br><br><br><br><div><span class="gmail_quote">On 3/26/07, <b class="gmail_sendername">Matthias Behnisch</b> <<a href="mailto:mat@4freax.net">mat@4freax.net</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Aaron<br><br>thats interesting, I made a similar change to icecast some time ago<br>myself. It writes ALL metadata to the log, not only ARTIST and TRACK. We<br>wanted to include more information into the playlist of our radio but
<br>unfortunately we discovered that oddcast doesn't send more than ARTIST<br>and TRACK... so I am looking for something that sends really everything.<br>What do you use as your stream source?<br><br>If you or someone else has interest I included a patch against
<br>icecast-2.3.1. yeah, I know its kind of a dirty.<br><br>Matthias<br><br>Aaron Gutierrez schrieb:<br>> Hi, i just joined the list. I was wondering if anyone would be<br>> interested in a change to icecast that logs album info as well as ARTST
<br>> and TRACK. I have made the changes to the source code and it's working<br>> fine. If there is any interest, I could look into making it an<br>> addition to the code.<br>><br>> Let me know.<br>>
<br>><br>> thanks,<br>><br>><br>><br>> --<br>> Aaron<br>><br>><br>> ------------------------------------------------------------------------<br>><br>> _______________________________________________
<br>> Icecast-dev mailing list<br>> <a href="mailto:Icecast-dev@xiph.org">Icecast-dev@xiph.org</a><br>> <a href="http://lists.xiph.org/mailman/listinfo/icecast-dev">http://lists.xiph.org/mailman/listinfo/icecast-dev
</a><br><br>diff -aur icecast-2.3.1/src/format_ogg.c icecast-2.3.1-modified/src/format_ogg.c<br>--- icecast-2.3.1/src/format_ogg.c 2005-08-19 04:01:58.000000000 +0200<br>+++ icecast-2.3.1-modified/src/format_ogg.c 2007-03-26 23:24:
51.000000000 +0200<br>@@ -184,12 +184,17 @@<br> void format_ogg_free_plugin (format_plugin_t *plugin)<br> {<br> ogg_state_t *state = plugin->_state;<br>+ int i;<br><br> /* free memory associated with this plugin instance */
<br> free_ogg_codecs (state);<br> free (state->artist);<br> free (state->title);<br><br>+ for(i=0; i < state->metadata_count; ++i)<br>+ free(state->metadata[i]);<br>+ free(state->metadata);
<br>+<br> ogg_sync_clear (&state->oy);<br> free (state);<br><br>@@ -268,6 +273,7 @@<br> unsigned int len = 1; /* space for the nul byte at least */<br> ogg_codec_t *codec;<br> char codec_names [100] = "";
<br>+ int i;<br><br> if (ogg_info->artist)<br> {<br>@@ -293,6 +299,17 @@<br> snprintf (metadata, len, "%s", title);<br> }<br> }<br>+<br>+ if (ogg_info->metadata_count > 0) {
<br>+ len += ogg_info->metadata_len;<br>+ if(metadata) metadata = realloc(metadata,len);<br>+ else metadata = calloc(1,len);<br>+ for(i=0; i < ogg_info->metadata_count; ++i) {<br>+ strcat(metadata,"|");
<br>+ strcat(metadata,ogg_info->metadata[i]);<br>+ }<br>+ }<br>+<br> if (metadata)<br> {<br> logging_playlist (source->mount, metadata, source->listeners);<br><br>diff -aur icecast-2.3.1
/src/format_ogg.h icecast-2.3.1-modified/src/format_ogg.h<br>--- icecast-2.3.1/src/format_ogg.h 2005-08-19 04:01:58.000000000 +0200<br>+++ icecast-2.3.1-modified/src/format_ogg.h 2007-03-26 23:15:51.000000000 +0200
<br>@@ -41,6 +41,11 @@<br> long bitrate;<br> struct ogg_codec_tag *current;<br> struct ogg_codec_tag *codec_sync;<br>+<br>+ char **metadata;<br>+ int metadata_count;<br>+ int metadata_len;<br>+<br> } ogg_state_t;
<br><br><br>diff -aur icecast-2.3.1/src/format_vorbis.c icecast-2.3.1-modified/src/format_vorbis.c<br>--- icecast-2.3.1/src/format_vorbis.c 2005-11-30 19:16:17.000000000 +0100<br>+++ icecast-2.3.1-modified/src/format_vorbis.c 2007-03-26 23:27:
23.000000000 +0200<br>@@ -511,6 +511,8 @@<br> vorbis_codec_t *source_vorbis = codec->specific;<br> char *comment;<br><br>+ int i;<br>+<br> if (ogg_stream_pagein (&codec->os, page) < 0)<br> {
<br> ogg_info->error = 1;<br>@@ -565,6 +567,21 @@<br> format_ogg_attach_header (ogg_info, page);<br> codec->process_page = process_vorbis_passthru_page;<br> }<br>+<br>+ //free previous comment fields
<br>+ for(i=0; i < ogg_info->metadata_count; ++i)<br>+ free(ogg_info->metadata[i]);<br>+ free(ogg_info->metadata);<br>+<br>+ ogg_info->metadata = calloc(source_vorbis->vc.comments,sizeof(char*));
<br>+<br>+ //copy all comment fields<br>+ ogg_info->metadata_count = source_vorbis->vc.comments;<br>+ ogg_info->metadata_len = source_vorbis->vc.comments; //space for tag separators<br>+ for(i=0; i < source_vorbis->
vc.comments; ++i) {<br>+ ogg_info->metadata[i] = strdup(source_vorbis->vc.user_comments[i]);<br>+ ogg_info->metadata_len += source_vorbis->vc.comment_lengths[i];<br>+ }<br><br> free (ogg_info->title);
<br> comment = vorbis_comment_query (&source_vorbis->vc, "TITLE", 0);<br>@@ -573,6 +590,7 @@<br> else<br> ogg_info->title = NULL;<br><br>+<br> free (ogg_info->artist);<br> comment = vorbis_comment_query (&source_vorbis->vc, "ARTIST", 0);
<br> if (comment)<br><br></blockquote></div><br><br clear="all"><br>-- <br>Aaron