[Icecast-dev] [PATCH] add with-openssl option

[Rosen Penev]

On Wed, Oct 7, 2020 at 3:43 AM Marvin Scholz <epirat07 at gmail.com> wrote:
>
> Hi, please provide the contents of the config.log
>
> I can not reproduce your issue on my machine, --without-openssl
> works fine here.
>
> Oh and next time please mention that its about libshout right
> away :)
https://gist.github.com/neheb/a26714035978d07a822985477524cd45
>
> On 7 Oct 2020, at 12:07, Rosen Penev wrote:
>
> > On Mon, Oct 5, 2020 at 9:59 PM Marvin Scholz <epirat07 at gmail.com>
> > wrote:
> >>
> >> Hi,
> > CC'd the mailing list.
> >>
> >> It seems you are not up to date, git master already has a
> >> --without-openssl option.
> > Without this patch, I get
> >
> > /bin/bash ../libtool  --tag=CC   --mode=link
> > mips-openwrt-linux-musl-gcc -Wall -ffast-math -fsigned-char
> > -I/home/build/build_dir/staging_dir/target-mips_24kc_musl/usr/include/tremor/
> > -Os -pipe -mno-branch-likely -mips32r2 -mtune=24kc -fno-caller-saves
> > -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable
> > -Wno-error=unused-result -msoft-float -mips16 -minterlink-mips16
> > -ffile-prefix-map=/home/build/build_dir/build_dir/target-mips_24kc_musl/libshout-nossl/libshout-2.4.4=libshout-2.4.4
> > -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1
> > -Wl,-z,now -Wl,-z,relro -fpic  -version-info 5:0:2
> > -L/home/build/build_dir/staging_dir/target-mips_24kc_musl/usr/lib
> > -L/home/build/build_dir/staging_dir/target-mips_24kc_musl/lib
> > -L/home/build/build_dir/staging_dir/toolchain-mips_24kc_gcc-8.4.0_musl/usr/lib
> > -L/home/build/build_dir/staging_dir/toolchain-mips_24kc_gcc-8.4.0_musl/lib
> > -znow -zrelro  -o libshout.la -rpath /usr/lib shout.lo util.lo
> > queue.lo connection.lo proto_http.lo proto_xaudiocast.lo proto_icy.lo
> > proto_roaraudio.lo format_ogg.lo format_webm.lo format_mp3.lo
> > codec_vorbis.lo codec_opus.lo   tls.lo common/net/libicenet.la
> > common/timing/libicetiming.la common/avl/libiceavl.la
> > common/httpp/libicehttpp.la common/thread/libicethread.la
> > -L/home/build/build_dir/staging_dir/target-mips_24kc_musl/usr/lib
> > -L/home/build/build_dir/staging_dir/target-mips_24kc_musl/lib
> > -L/home/build/build_dir/staging_dir/toolchain-mips_24kc_gcc-8.4.0_musl/usr/lib
> > -L/home/build/build_dir/staging_dir/toolchain-mips_24kc_gcc-8.4.0_musl/lib
> > -znow -zrelro -lvorbisidec   -Lno/lib -lssl
> > ../libtool: line 5992: cd: no/lib: No such file or directory
> > OpenWrt-libtool: link: cannot determine absolute directory name of
> > `no/lib'
> >
> >>
> >> On 6 Oct 2020, at 0:42, Rosen Penev wrote:
> >>
> >>> Useful for embedded systems.
> >>>
> >>> Signed-off-by: Rosen Penev <rosenp at gmail.com>
> >>> ---
> >>>  m4/xiph_openssl.m4 | 18 ++++++++++--------
> >>>  1 file changed, 10 insertions(+), 8 deletions(-)
> >>>
> >>> diff --git a/m4/xiph_openssl.m4 b/m4/xiph_openssl.m4
> >>> index f62a524..52308ec 100644
> >>> --- a/m4/xiph_openssl.m4
> >>> +++ b/m4/xiph_openssl.m4
> >>> @@ -29,14 +29,16 @@ else
> >>>      fi
> >>>  fi
> >>>
> >>> -# Now try linking to openssl
> >>> -xt_save_CFLAGS="$CFLAGS"
> >>> -xt_save_LIBS="$LIBS"
> >>> -CFLAGS="$CFLAGS $OPENSSL_CFLAGS"
> >>> -LIBS="$OPENSSL_LIBS $LIBS"
> >>> -AC_TRY_LINK([#include <openssl/ssl.h>], [void *a = SSL_new],
> >>> [openssl_ok='yes'])
> >>> -CFLAGS="$xt_save_CFLAGS"
> >>> -LIBS="$xt_save_LIBS"
> >>> +if test "x$openssl_prefix" != "xno"; then
> >>> +    # Now try linking to openssl
> >>> +    xt_save_CFLAGS="$CFLAGS"
> >>> +    xt_save_LIBS="$LIBS"
> >>> +    CFLAGS="$CFLAGS $OPENSSL_CFLAGS"
> >>> +    LIBS="$OPENSSL_LIBS $LIBS"
> >>> +    AC_TRY_LINK([#include <openssl/ssl.h>], [void *a = SSL_new],
> >>> [openssl_ok='yes'])
> >>> +    CFLAGS="$xt_save_CFLAGS"
> >>> +    LIBS="$xt_save_LIBS"
> >>> +fi
> >>>
> >>>  if test "$openssl_ok" = "yes"; then
> >>>      AC_DEFINE(HAVE_OPENSSL, 1, [Define if you have libopenssl.])
> >>> --
> >>> 2.26.2
> >>>
> >>> _______________________________________________
> >>> Icecast-dev mailing list
> >>> Icecast-dev at xiph.org
> >>> http://lists.xiph.org/mailman/listinfo/icecast-dev
> _______________________________________________
> Icecast-dev mailing list
> Icecast-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/icecast-dev