[Icecast-dev] Segmentation Fault

[voice]

Did a little more digging on this and found that source_real wasn't being
checked to see if it was null or not. The attached patch seems to be
holding up so far on my server.

On Sat, Oct 1, 2016 at 7:55 PM, voice <voice06 at gmail.com> wrote:

> Hello,
>
> I have a Icecast server, source code pulled from git, that constantly
> segfaults when the playlist stats start populating. I ran GDB on it and got
> this
>
> Program received signal SIGSEGV, Segmentation fault.
> _dump_stats_to_doc (hidden=0, show_mount=0x0, root=0x676e50) at stats.c:881
> 881            history = playlist_render_xspf(source_real->history);
>
>
> which falls in line with
>
> [24699945.204767] icecast[23864]: segfault at 118 ip 0000000000414be5 sp
> 00007ffe8ace7050 error 4 in icecast[400000+3c000]
> addr2line -e /path/to/icecast 0000000000414be5
> /path/to/icecast_git/icecast-server/src/stats.c:881
>
> OS: Debian Jessie
> Current Git commit: 72075d0d0dd97c54d2317b325bfec55a7d496f82
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/icecast-dev/attachments/20161002/07af121f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: source_real.patch
Type: text/x-patch
Size: 1883 bytes
Desc: not available
URL: <http://lists.xiph.org/pipermail/icecast-dev/attachments/20161002/07af121f/attachment.bin>