[Icecast-dev] version 2.3.3, file log.c bug report

[Philipp Schafft]

reflum,

On Fri, 2013-06-28 at 09:22 +0000, David Binderman wrote:
> Hello there,
> 
> I just ran the static analysis checker "cppcheck" over the source code
> of icecast version 2.3.3
> 
> Amongst many other things, it said
> 
> [log.c:301]: (warning) Logical conjunction always evaluates to false: log_id < 0 && log_id>= 25.
> 
> Source code is
> 
>     if (log_id < 0 && log_id>= LOG_MAXLOGS)
>         return;
> 
> Suggest replace && with ||.

Thanks for reporting. I just commited the change as r18961.

Have a nice day!

-- 
Philipp.
 (Rah of PH2)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: This is a digitally signed message part
Url : http://lists.xiph.org/pipermail/icecast-dev/attachments/20130704/07c11d97/attachment.pgp