[Icecast-dev] [PATCH] include mount point from single text files in a given directory

[thomas.ruecker at tieto.com]

Hi,

>-----Original Message-----
>From: marco
>
>Il giorno 20/feb/2012, alle ore 23:10, Ralph Giles ha scritto:
>>  sounds like this is more like a general config file include 
>> mechanism. If so, it would make more sense to use <include> than 
>> <mount-include>
>
>The second version i sent includes an explicit check that allows to 
>include the external xml element only if it is named "mount". Yes, the 
>whole logic can be used for a more general xml include, but it was out 
>of the scope of this simple patch.

Hmm, I don't have the time to dive into this right now, but before this
goes much further I'd like to remark, that XML itself supports includes
and that works with Icecast already. I remember someone trying it out.

It would probably need to be revisited as I seem to remember, that 
there was a bug and when HUP'ing the server it wouldn't read includes.

I'd rather see that XML functionality working properly than 
an Icecast specific patch.

Cheers

Thomas