[Icecast-dev] [PATCH] - Make reopening of Log files

[Henning Schmiedehausen]

independent from Configuration Reload
In-Reply-To: <200406161051.03808.msmith at xiph.org>
References: <1087307353.28637.11.camel at forge.intermeta.de>
<200406161051.03808.msmith at xiph.org>
Message-ID: <1087392799.7778.4.camel at forge.intermeta.de>

Hi,

yes, I tested the patch. Then I sent you the wrong version. I attached
the correct one. Yes, this one works.

Why just reopening the log files and not reloading the configuration?
Well, with regular log file rotation, you have a cron job sending this
signal to the process once in a while. If an attacker manages to change
the configuration, the process will sooner or later reload this changed
configuration.

If the signal just reopens the log files, this is not possible.

I added a short doc file, but as the HUP signal isn't documented better,
there is not much to say here. :-)

Regards
Henning

On Wed, 2004-06-16 at 02:51, Michael Smith wrote:
> On Tuesday 15 June 2004 23:49, Henning Schmiedehausen wrote:
> > Hi,
> >
> > this patch allows the icecast streamer to react on SIGUSR1 and just to
> > reopen its log files. I don't like the fact that the whole configuration
> > is reread on SIGHUP.
> >
> > Please apply for 2.0.2
> >
> > 	Regards
> > 		Henning
>
> Did you actually test this patch? It doesn't look like it'll work.
>
> It's also undocumented - and given problems with this in the past, we're not
> going to put new features in without documentation.
>
> I'm not opposed to the actual feature... but what's wrong with the
> configuration being re-read - is it causing you any actual problems? If so,
> what?
>
> Mike
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps at intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training, Development

"Fighting for one's political stand is an honourable action, but re-
fusing to acknowledge that there might be weaknesses in one's
position - in order to identify them so that they can be remedied -
is a large enough problem with the Open Source movement that it
deserves to be on this list of the top five problems."
--Michelle Levesque, "Fundamental Issues with
Open Source Software Development"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icecast-2.0.1-reload-logfile.patch
Type: text/x-patch
Size: 4258 bytes
Desc: not available
Url : http://westfish.xiph.org/pipermail/icecast-dev/attachments/20040616/56fb6251/icecast-2.0.1-reload-logfile.bin