[icecast-dev] Re: [icecast] Announcing Version 2.0.0 of Icecast

[Krištof Petr]

oddsock wrote:

> After many years of development and testing, icecast has finally moved 
> to 2.0.0.

Great.

I quickly looked at srpm package. My comments:

- %changelog is empty. No name/contact of current rpm maintainer who to 
send fixies

- dependencies are dubbed. libvorbis has defined 'require libogg' already.
   Chain icecast->libvorbis->libogg is enought

- %build is done by bad way. You can define all options by hand, but you 
ususaly
   forget something. Actualy author did forget --localstatedir or 
something similiar
   and the result is icecast.xml where line
   <logdir>/usr/var/log/icecast</logdir>
   is evidently wrong.
   It is better to use rpm macro %configure instead, what sets 
everything correctly.

<p>Regs
Petr

<p>====================================

%prep
%setup

%build
%configure
make

<p>%install

=====================================

<p><p>--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.