[icecast-dev] Re: PATCH: increase network congestion resilience

[Michael Smith]

> Because a refbuf is a page, we could drop them all but the logical stream
> headers, which are cached and sent first (easy to check). So, before
> discarding a page, we should check is "complete" (in the sense that the
> headers were not already sent, i.e. client->pos == 0) and that is not a a
> pre_data.

Yes. This is possible, (in fact, the refbufs have to be explicitly tagged as 
being droppable or not, we can't discover it after the fact), but it's added 
complexity for a feature which is of very dubious benefit anyway. The 
processing model of icecast assumes a continuous connection - if they can't 
keep up, the client will probably drop anyway. It's much better to just let 
the client auto-reconnect (which most of them do).

Mike

--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.