[icecast-dev] PATCH: increase network congestion resilience (SOLVED!)

Michael Smith msmith at xiph.org
Sat Jan 18 04:29:43 PST 2003

> Goddam!!!!
> There were bugs in icecast2 while checking for recoverable error (in
> several places indeed).
> The program was checking for sock_recoverable() with the return value of
> send(), which is a mistake and confused me because I assumed it was
> right. It _must_ be done against with sock_error() instead.
> Find the patch that solves the bugs.

Ah! Good catch, thanks for these. That was a pretty nasty little error...
The first two fixes in this patch are correct, and have been applied.
The second two are unneccesary, since source->format->write_buf_to_client() is 
required to return less than 0 _only_ if a fatal error occurs (which with the 
first two fixes is now done correctly).



--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.

More information about the Icecast-dev mailing list