[icecast-dev] Extensive definitions with reserved identifiers

Ingolf Steinbach Ingolf.Steinbach at jena-optronik.de
Tue Dec 2 03:18:09 PST 2003


the icecast source code contains many definitions with identifiers
reserved in C. For instance, include guards typically are
__LIKE_THIS__ (note the underscores at the beginning).

While gcc does not complain about these, they might lead to
problems with other compilers (or a future gcc release) and
also make code analyzers complain. For an overview of reserved
identifers, see for instance

Could you please modify the icecast source to avoid reserved
identifiers? For instance, a completely valid scheme for
include guard naming (which also avoids name clashes) could
static functions could be named icecastDoSomething() rather
than _doSomething().

If you are interested, I could generate a patch.

Kind regards



Ingolf Steinbach                       Jena-Optronik GmbH
ingolf.steinbach at jena-optronik.de       ++49 3641 200-147
PGP: 0x7B3B5661  213C 828E 0C92 16B5  05D0 4D5B A324 EC04

--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.

More information about the Icecast-dev mailing list