[icecast-dev] Stream metadata settings

[Karl Heyes]

On Mon, 2003-12-01 at 13:52, Melanie wrote:
> True - in that case, another fix ist called for, but it's just as simple:
> 
> diff -b -B -r -u -P --exclude-from=ignore ../icecast/src/source.c 
> ./src/source.c--- ../icecast/src/source.c Mon Dec  1 14:49:52 2003
> +++ ./src/source.c  Mon Dec  1 14:50:56 2003
> @@ -72,7 +72,7 @@
>       src->yp_public = 0;
> 
>       if(mountinfo != NULL) {
> -        src->fallback_mount = mountinfo->fallback_mount;
> +        src->fallback_mount = (char *)strdup(mountinfo->fallback_mount);
>           src->max_listeners = mountinfo->max_listeners;
>           src->dumpfilename = mountinfo->dumpfile;
>       }

2 things...

- you missed dumpfile which also has the same issue :)

- the config lock really needs to be taken.  You don't want the
mountinfo details to disappear which it could do if the config file
was switched over. 

>From looking at it we could just re-take the config lock within this
function, the users of this function don't have the lock at the time
this is invoked.

karl.

<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.