<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 25.5.2013 15:42, Ulrich Klauer
wrote:<br>
</div>
<blockquote
cite="mid:20130525144208.Horde.31n7T4vKlfCDab8kkXQvfw1@webmail.df.eu"
type="cite">Janne Hyvärinen wrote:
<br>
<br>
<blockquote type="cite">On 25.5.2013 10:54, Erik de Castro Lopo
wrote:
<br>
<blockquote type="cite">Robert Kausch wrote:
<br>
</blockquote>
</blockquote>
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">I tried 1.3.0pre4 with ICL on Windows
and found some issues.
<br>
</blockquote>
</blockquote>
</blockquote>
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">The first two are quite straight
forward:
<br>
<br>
- The ICL patch fixes a typo in bitmath.h and adds
<br>
FLAC__bitwriter_write_zeroes to the external declarations in
bitwriter.c.
<br>
- The Ogg patch replaces the check for
FLAC_API_SUPPORTS_OGG_FLAC in
<br>
stream_decoder.c with FLAC__HAS_OGG to fix compilation with
Ogg support.
<br>
<br>
The _lseeki64 patch probably is a little more controversial.
<br>
</blockquote>
</blockquote>
</blockquote>
<br>
<blockquote type="cite">
<blockquote type="cite">Sorry, I've read through this thread and
can't figure out what was
<br>
actually decided and which patch I should be looking at.
<br>
</blockquote>
</blockquote>
<br>
<blockquote type="cite">None.
<br>
</blockquote>
<br>
I think the first two patches should actually go in.
<br>
<br>
- The second patch absolutely, because it fixes an all-platform
regression. (Actually, slightly modified perhaps; or even better,
we revert this part to how it was in 1.2.1. Attaching a patch to
do that.)
<br>
<br>
- The first patch addresses two different issues. I've split it
into two patches (also attached). One of them fixes a mistyped
variable name that will obviously cause the Intel compiler to
fail. Regarding the other, well, it is certainly consistent with
the other external declarations, and if it helps the Intel
compiler, why not?
<br>
<br>
Ulrich
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
flac-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a>
<a class="moz-txt-link-freetext" href="http://lists.xiph.org/mailman/listinfo/flac-dev">http://lists.xiph.org/mailman/listinfo/flac-dev</a>
</pre>
</blockquote>
<br>
Ah indeed, I have nothing against those. I should have read all the
quoted text.<br>
</body>
</html>