Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein as the other patches, this patch consists of minor reworks of functions/commands as well as heavily commenting what's going on.<br><br>More than halfway there!<br>
<br>Thanks,<br>Jaren<br><br>On Tue, Mar 12, 2013 at 9:40 PM, Erik de Castro Lopo <<a href="mailto:mle%2Bla@mega-nerd.com">mle+la@mega-nerd.com</a>> wrote:<br>><br>> Jaren Stangret wrote:<br>><br>> > Interestingly, I noticed compression level '0' is omitted, so I've added it<br>
> > in.<br>><br>> Thanks.<br>><br>> > Also, I tested this on a 24bit/96kHz FLAC file and the test failed between<br>> > compression level 0 and compression level 1 -- the file size was greater<br>
> > with a compression level of 1, rather than 0. The test works on<br>> > 'noisy-sine.wav'. It may be worth trying to run this test on a variety of<br>> > FLAC files (multiple channels, multiple bps, multiple sample rates, etc).<br>
><br>> Compression levels are always highly dependent on the source material. This<br>> particular test was added to test for the most gross kind of regressions<br>> like the one I fixed in fc360735ce4d1aa88a94bfccdd3bea5bdd19a8d6.<br>
><br>> When and if we come to update/improve FLAC's core compression code, that<br>> is when we would need a more comprehensive test for compressed file sizes.<br>><br>> At this point, I think what we have is sufficient.<br>
><br>> Cheers,<br>> Erik<br>> --<br>> ----------------------------------------------------------------------<br>> Erik de Castro Lopo<br>> <a href="http://www.mega-nerd.com/">http://www.mega-nerd.com/</a><br>
> _______________________________________________<br>> flac-dev mailing list<br>> <a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>> <a href="http://lists.xiph.org/mailman/listinfo/flac-dev">http://lists.xiph.org/mailman/listinfo/flac-dev</a><br>